Repository navigation
Avoid overflow in validation error capacity - #3772
Merged
Merged
Conversation
Co-authored-by: Copilot App <[email protected]>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported, and the change includes regression coverage for the overflow-prone error-list formatting path.
No open issues 🎉
What changed in this PR
This pull request prevents integer overflow when formatting GitHub validation errors by removing unchecked slice-capacity preallocation while preserving existing output.
Changes:
- Removes the
len(errors) + 1capacity calculation. - Adds regression coverage for formatting large validation-error lists.
- Reorders test imports to follow Go formatting conventions.
| File | Description |
|---|---|
pkg/errors/error.go |
Removes the overflow-prone validation-error slice capacity calculation. |
pkg/errors/error_test.go |
Adds regression coverage for large validation-error lists and updates imports. |
Review effort: Lite (auto)
almaleksia
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid preallocating the validation-error parts slice from an unchecked
len(errors) + 1capacity calculation, while preserving the formatted error output.Why
The public code-scanning alert flags the capacity calculation as potentially overflowing when formatting GitHub validation errors.
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testResults:
script/lint— passed;script/test— passed.Docs