Sitelet https://github.com/github/codeql-action/pull/3569/commits/70d5cccce1eee0c7c10efd0c96d692c14c5b7a49
Skip to content

Disable TRAP caching when overlay is enabled #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 13 commits into from
Mar 19, 2026
Merged

Disable TRAP caching when overlay is enabled #3569

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b0f8772
Add FF for disabling TRAP caching when overlay enabled
henrymercer Mar 11, 2026
b04e63f
Enablement: Move TRAP caching check after overlay
henrymercer Mar 11, 2026
70d5ccc
Disable TRAP caching when conditions met
henrymercer Mar 11, 2026
d05b50b
Clean up: Remove unneeded CodeQL version guard
henrymercer Mar 11, 2026
d74701c
Drive-by cleanup: Always use `--cache-cleanup`
henrymercer Mar 11, 2026
19544bb
Remove dead Python library extraction code
henrymercer Mar 11, 2026
556dd79
Drive-by comment fixes
henrymercer Mar 11, 2026
a91b7a3
Add unit tests for `isTrapCachingEnabled`
henrymercer Mar 11, 2026
b1f1e7b
Add changelog note
henrymercer Mar 11, 2026
926e6df
Stub RUNNER_NAME in unit tests
henrymercer Mar 11, 2026
60a0dce
Merge branch 'main' into henrymercer/overlay-no-trap-caching
henrymercer Mar 18, 2026
582d08c
Explicitly set C/C++ trap caching env var to false
henrymercer Mar 18, 2026
5b63048
Fix changelog automerge
henrymercer Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable TRAP caching when conditions met
  • Loading branch information
@henrymercer
henrymercer committed Mar 11, 2026
commit 70d5cccce1eee0c7c10efd0c96d692c14c5b7a49
5 changes: 4 additions & 1 deletion lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 11 additions & 2 deletions src/config-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,8 +999,8 @@ async function validateOverlayDatabaseMode(
}

async function isTrapCachingEnabled(
_features: FeatureEnablement,
_overlayDatabaseMode: OverlayDatabaseMode,
features: FeatureEnablement,
overlayDatabaseMode: OverlayDatabaseMode,
): Promise<boolean> {
// If the workflow specified something always respect that
const trapCaching = getOptionalInput("trap-caching");
Expand All @@ -1009,6 +1009,15 @@ async function isTrapCachingEnabled(
// On self-hosted runners which may have slow network access, disable TRAP caching by default
if (!isHostedRunner()) return false;

// If overlay analysis is enabled, then disable TRAP caching since overlay analysis supersedes it.
// This change is gated behind a feature flag.
if (
overlayDatabaseMode !== OverlayDatabaseMode.None &&
(await features.getValue(Feature.OverlayAnalysisDisableTrapCaching))
) {
return false;
}

// Otherwise, enable TRAP caching
return true;
}
Expand Down