Sitelet https://github.com/github/codeql-action/pull/3542/commits/8e17ec94b44304883dbeec7a301637844d50aac0
Skip to content

Run some unit tests in parallel #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 5 commits into from
Mar 4, 2026
Merged

Run some unit tests in parallel #3542

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
675af55
Run some unit tests in parallel
henrymercer Mar 4, 2026
36148cc
Run more actions util tests serially
henrymercer Mar 4, 2026
aae9418
Fix test name
henrymercer Mar 4, 2026
8e17ec9
Merge branch 'main' into henrymercer/parallel-unit-tests
henrymercer Mar 4, 2026
6123416
Merge remote-tracking branch 'origin/main' into henrymercer/parallel-…
henrymercer Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into henrymercer/parallel-unit-tests
  • Loading branch information
@henrymercer
henrymercer committed Mar 4, 2026
commit 8e17ec94b44304883dbeec7a301637844d50aac0
22 changes: 11 additions & 11 deletions src/overlay/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,14 +209,14 @@ const testDownloadOverlayBaseDatabaseFromCache = test.macro({
title: (_, title) => `downloadOverlayBaseDatabaseFromCache: ${title}`,
});

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns stats when successful",
{},
true,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when mode is OverlayDatabaseMode.OverlayBase",
{
Expand All @@ -225,7 +225,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when mode is OverlayDatabaseMode.None",
{
Expand All @@ -234,7 +234,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when caching is disabled",
{
Expand All @@ -243,7 +243,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined in test mode",
{
Expand All @@ -252,7 +252,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when cache miss",
{
Expand All @@ -261,7 +261,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when download fails",
{
Expand All @@ -270,7 +270,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when downloaded database is invalid",
{
Expand All @@ -279,7 +279,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when downloaded database doesn't have an overlayBaseSpecifier",
{
Expand All @@ -288,7 +288,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when resolving database metadata fails",
{
Expand All @@ -297,7 +297,7 @@ test(
false,
);

test(
test.serial(
testDownloadOverlayBaseDatabaseFromCache,
"returns undefined when filesystem error occurs",
{
Expand Down
32 changes: 32 additions & 0 deletions src/start-proxy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,38 @@
},
);

test.serial(
"getCredentials returns all credentials for Actions when using LANGUAGE_TO_REGISTRY_TYPE",
async (t) => {
const credentialsInput = toEncodedJSON(mixedCredentials);

const credentials = startProxyExports.getCredentials(
getRunnerLogger(true),
undefined,
credentialsInput,
KnownLanguage.actions,
false,
);
t.is(credentials.length, mixedCredentials.length);
},
);

test.serial(
"getCredentials returns no credentials for Actions when using NEW_LANGUAGE_TO_REGISTRY_TYPE",
async (t) => {
const credentialsInput = toEncodedJSON(mixedCredentials);

const credentials = startProxyExports.getCredentials(
getRunnerLogger(true),
undefined,
credentialsInput,
KnownLanguage.actions,
true,
);
t.deepEqual(credentials, []);
Comment thread
henrymercer marked this conversation as resolved.
Dismissed
},
);

test.serial("parseLanguage", async (t) => {
// Exact matches
t.deepEqual(parseLanguage("csharp"), KnownLanguage.csharp);
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.