Sitelet https://github.com/github/codeql-action/pull/3538/commits/d1c255c293cad54704d0f466c029477da4a0e569
Skip to content

Break down overlay disabled reason #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 15 commits into from
Mar 5, 2026
Merged

Break down overlay disabled reason #3538

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0158d05
Make "feature not enabled" reason more specific
henrymercer Mar 3, 2026
9f77ff1
Make "insufficient resources" reason more specific
henrymercer Mar 3, 2026
eddf336
Sort `OverlayDisabledReason` enum
henrymercer Mar 3, 2026
f654d61
Add JSDoc
henrymercer Mar 3, 2026
776fd85
Address review comments
henrymercer Mar 3, 2026
b371ccd
Refactor `getOverlayDatabaseMode` and add new disablement reason
henrymercer Mar 4, 2026
d1c255c
Update `NonDefaultQueries` documentation
henrymercer Mar 4, 2026
be20394
Rename to `usesDefaultQueriesOnly`
henrymercer Mar 4, 2026
6a77217
Add disabled by env var disablement reason
henrymercer Mar 4, 2026
5fa8dad
Use `Result`s for enablement return types
henrymercer Mar 4, 2026
4cd47ad
Address review comments
henrymercer Mar 4, 2026
7449e32
Rename to `EnabledOverlayConfig`
henrymercer Mar 4, 2026
60a0e2b
Update method naming and JSDoc
henrymercer Mar 4, 2026
759b5db
Merge branch 'main' into henrymercer/breakdown-overlay-disabled-reason
henrymercer Mar 4, 2026
6d1c37e
Fix some tests that should be serial
henrymercer Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update NonDefaultQueries documentation
  • Loading branch information
@henrymercer
henrymercer committed Mar 4, 2026
commit d1c255c293cad54704d0f466c029477da4a0e569
6 changes: 4 additions & 2 deletions src/overlay/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ export enum OverlayDisabledReason {
/** The source root is not inside a git repository. */
NoGitRoot = "no-git-root",
/**
* Overlay analysis is restricted to code-scanning-only configs but the config uses custom
* queries or packs, disables default queries, or specifies query filters.
* For one or more of the configured languages, overlay analysis is only
* enabled when using the default query suite, but the config customises the
* queries by disabling default queries, specifying custom queries or packs,
* or adding query filters.
*/
NonDefaultQueries = "non-default-queries",
/** We are not analyzing a pull request or the default branch. */
Expand Down