Repository navigation
Conversation
Repeating Bazel's module identity and build topology gives maintainers another description to keep aligned. MODULE.bazel already declares the module identity and internal-module override. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/MODULE.bazel#L1-L13 Standalone resolution is configured in .bazelrc. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/.bazelrc#L11-L14 The skill's Building standalone section retains the override-pair restriction, narrow stub-extension condition and internal-target prohibition. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/.github/skills/bazel/SKILL.md#L151-L174 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stating the same target-copying duty twice gives maintainers two versions to keep aligned. The rest of the same bullet already requires the closest working neighbor and prefers wrappers for new code, while explaining the mixed packaging conventions. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/.github/skills/bazel/SKILL.md#L30-L31 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
A fix to injected Cargo or IDE sources can remain absent from Bazel's generator inputs, so finding the persistent edit target matters. The Bazel target excludes local src/codegen files and supplies them from the external rust-analyzer archive. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/rust/ast-generator/BUILD.bazel#L23-L50 That archive applies rust/ast-generator/patches/rust-analyzer.patch, making the tracked patch the place to retain such source changes. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/MODULE.bazel#L209-L218 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
An introductory summary of the active language and parser backend gives maintainers another implementation description to update as the extractor evolves. Language registration already identifies Swift as the active front end. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/unified/extractor/src/languages/mod.rs#L3-L20 The parser calls swift_syntax_rs::parse_to_json and adapts its result directly. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/unified/extractor/src/languages/swift/parse.rs#L11-L21 The task-directed Swift Parser and AST Mapping sections retain parser navigation, the in-process warning, schema regeneration and test prerequisites. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/unified/AGENTS.md#L10-L32 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Maintainers should not have to align two versions of the same hand-edit restriction for Unified expected files. The root expected-file instruction already applies to every .expected file and includes the nonempty-testFailures safeguard. https://github.com/github/codeql/blob/d1caf2a1b4e8f0209fa7af81be129278e6dd8f56/.github/instructions/expected-files.instructions.md#L1-L4 That scoped instruction remains the prohibition's owner; Unified retains its existing runner-based update recipe. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, and the documented guidance-only changes do not affect build, parser, or test behavior.
No open issues 🎉
What changed in this PR
This PR streamlines repository guidance for Copilot and maintainers without changing build, parser, or test behavior.
Changes:
- Removes duplicated Unified architecture and expected-output guidance.
- Simplifies Bazel setup and neighboring-target instructions.
- Documents the tracked Rust Analyzer patch as the persistence point for injected Rust source changes.
| File | Description |
|---|---|
| unified/AGENTS.md | Removes redundant architecture and expected-output editing guidance while retaining the --learn workflow. |
| rust/ast-generator/README.md | Identifies the tracked patch used to preserve injected Rust source changes in Bazel builds. |
| .github/skills/bazel/SKILL.md | Removes duplicated Bazel setup and neighboring-target guidance. |
Review effort: Lite (dynamic)
asgerf
reviewed
Nov 13, 2026
asgerf
left a comment
Contributor
There was a problem hiding this comment.
Changes to unified LGTM. Can't really comment on the Rust or Bazel docs though.
Contributor
|
The Rust change seems ok to me. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧠 How this helps Copilot
Bazel's setup recap and repeated neighboring-target instruction, together with Unified's architecture recap, give maintainers extra descriptions to keep aligned. Removing them avoids that duplicated upkeep without changing build or parser behavior.
Injected Rust source edits can appear correct to Cargo while remaining absent from Bazel's external inputs. Naming the tracked rust-analyzer patch beside the injection command gives Copilot the persistent edit target without another source-selection detour.
Unified repeats a hand-edit restriction that the same readers already receive from the root
.expected-file instruction. Removing the Unified copy avoids maintaining a second prohibition while retaining its--learnupdate recipe.Review commit by commit for each change's rationale and evidence.
Note
Copilot Dreaming curates this repository's Copilot instructions and skills in the background, proposing updates to help agents work here. Learn more about Copilot Dreaming.
Automated details
Source:
curate-memoriesDream, analyzingmainatd1caf2a1b4e8.Discarded guidance: A change to Unified's full-test command was withheld because this checkout does not establish the external runner's option contract; the command remains unchanged.