Repository navigation
LGTM.com - false positive for move and copy assignment operators not returning *this (C++) #7035
Description
The error is reported for these operators when *this is returned indirectly via a function call. For example:
we have:
return value::move_assign<T>(*this, std::forward<basic_node>(o));where value::move_assign returns its first argument, which is *this.
Reacted by Geoffrey White and oknenavin
Activity
adityasharad commentedon Nov 2, 2021
Thanks for the report! At a brief glance I agree this looks like a false positive. The code you link to implements
operator=using a templatedmove_assignfunction, which appears to return*thisin all code paths, but the analysis used by this particular query has not taken that fact into account.I have passed your suggestion on to the CodeQL C/C++ analysis team. Our current focus is on improving our security analysis. Because your report does not relate to a security query, we will put this on our backlog and prioritize it if we get enough reports of the same underlying issue in other projects. (If you think that your report is related to our security analysis, please clarify that in a comment.) We'll let you know here as soon as it's fixed.
In the meantime, GitHub Code Scanning and lgtm.com have facilities for suppressing individual alerts or disabling a query: please feel free to use those features as appropriate in your codebase, particularly if these alerts are proving noisy.
oknenavin commentedon Nov 2, 2021
Thanks a lot for the quick response! Well, gaps in code analysis are always a security risk, no? ;)
Thanks again - I'll check how to suppress these gracefully as I don't want to cheat the system. :)
- lgtm [cpp/assignment-does-not-return-this] (false-positive: github/…
- lgtm [cpp/assignment-does-not-return-this] (false-positive: github/…
- lgtm [cpp/assignment-does-not-return-this] (false-positive: github/…
index on develop: 30b7d8d - lgtm [cpp/assignment-does-not-return-this…