fix(gcp): Gate request body collection on data_collection experiment - #7254
Open
ericapisani wants to merge 1 commit into
Open
fix(gcp): Gate request body collection on data_collection experiment#7254ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Attach request.data based on the data_collection experiment's http_bodies["incoming_request"] setting when configured, falling back to should_send_default_pii() otherwise. Refs PY-2419 Refs #6283
Contributor
Codecov Results 📊✅ 118005 passed | ⏭️ 6732 skipped | Total: 124737 | Pass Rate: 94.6% | Execution Time: 415m 30s 📊 Comparison with Base Branch
➖ Removed Tests (2)View removed tests
All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 2488 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.22% 90.23% +0.01%
==========================================
Files 193 193 —
Lines 25435 25461 +26
Branches 9346 9368 +22
==========================================
+ Hits 22947 22973 +26
- Misses 2488 2488 —
- Partials 1434 1433 -1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attach request.data based on the data_collection experiment's http_bodies["incoming_request"] setting when configured, falling back to should_send_default_pii() otherwise.
Refs PY-2419
Refs #6283