Sitelet https://github.com/getsentry/sentry-python/pull/7252
Skip to content

fix(fastapi): Gate request body collection on data_collection experiment - #7252

Open
ericapisani wants to merge 1 commit into
py-2419-request-body-dramatiqfrom
py-2419-request-body-fastapi
Open

fix(fastapi): Gate request body collection on data_collection experiment#7252
ericapisani wants to merge 1 commit into
py-2419-request-body-dramatiqfrom
py-2419-request-body-fastapi

Conversation

@ericapisani

Copy link
Copy Markdown
Member

Only attach request body data to events and spans when "incoming_request" is present in the data_collection.http_bodies experiment option (or when the experiment is unset, preserving default behavior).

Refs PY-2419
Refs #6283

@ericapisani
ericapisani requested a review from a team as a code owner August 25, 2026 19:49
@linear-code

linear-code Bot commented Aug 25, 2026

Copy link
Copy Markdown

PY-2419

Only attach request body data to events and spans when
"incoming_request" is present in the data_collection.http_bodies
experiment option (or when the experiment is unset, preserving
default behavior).

Refs PY-2419
Refs #6283
@ericapisani
ericapisani force-pushed the py-2419-request-body-fastapi branch from bf18239 to fad152e Compare August 25, 2026 19:49
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

117888 passed | ⏭️ 6732 skipped | Total: 124620 | Pass Rate: 94.6% | Execution Time: 416m 22s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +219
Passed Tests 📈 +221
Failed Tests 📉 -2
Skipped Tests

➖ Removed Tests (2)

View removed tests
  • test_continuous_profiler_auto_start_and_stop_sampled[non-experiment-gevent]
    • File: tests.profiler.test_continuous_profiler
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-gevent]
    • File: tests.profiler.test_continuous_profiler

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2487 uncovered lines.
✅ Project coverage is 90.23%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.22%    90.23%    +0.01%
==========================================
  Files          193       193         —
  Lines        25435     25451       +16
  Branches      9346      9360       +14
==========================================
+ Hits         22947     22964       +17
- Misses        2488      2487        -1
- Partials      1434      1435        +1

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant