fix(dramatiq): Gate request body collection on data_collection experiment - #7250
Open
ericapisani wants to merge 2 commits into
Open
fix(dramatiq): Gate request body collection on data_collection experiment#7250ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
…ment Only attach dramatiq message data to the event when the data_collection experiment's http_bodies config includes "incoming_request", matching the behavior in other integrations (e.g. aiohttp). The "dramatiq" context type is still always set. Refs PY-2419 Refs #6283
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 278b786. Configure here.
Contributor
Codecov Results 📊✅ 117748 passed | ⏭️ 6732 skipped | Total: 124480 | Pass Rate: 94.59% | Execution Time: 416m 48s 📊 Comparison with Base Branch
➖ Removed Tests (2)View removed tests
All tests are passing successfully. ✅ Patch coverage is 88.89%. Project has 2486 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.22% 90.23% +0.01%
==========================================
Files 193 193 —
Lines 25435 25443 +8
Branches 9346 9354 +8
==========================================
+ Hits 22947 22957 +10
- Misses 2488 2486 -2
- Partials 1434 1433 -1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only attach dramatiq message data to the event when the data_collection experiment's http_bodies config includes "incoming_request", matching the behavior in other integrations (e.g. aiohttp). The "dramatiq" context type is still always set.
Refs PY-2419
Refs #6283