chore(logging): Clean up LoggingIntegration - #7248
Draft
sentrivana wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Get the logging integration into better shape now that Sentry Logs are a first-class feature. The idea is to make Logs the primary feature the integration offers, with capturing breadcrumbs and events an optional add-on.
High-level overview of the changes:
level(before:sentry_logs_level),ignore_logger(before:ignore_logger_for_sentry_logs) now set the Sentry logs level and Sentry logs denylist, respectively.level->breadcrumb_level,ignore_logger->ignore_logger_for_events).capture_sentry_logsoption is gone completely. Since logs instrumentation is now on by default, and theleveloption exists, it was superfluous. Capturing logs can still be opted out of by settinglevel=None.Issues
Closes #7246