Repository navigation
test(core): Fix flaky span end timestamp test - #25211
Merged
Merged
Conversation
Since #24903, a span's end time is its start time plus the `performance.now()` duration. It can differ from a `timestampInSeconds()` value taken while the span runs by fractions of a microsecond in either direction, so `toBeGreaterThanOrEqual(now)` failed in about 15% of runs. Assert what the code guarantees instead: the end time is never before the start time, and it is close to the current time. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
marked this pull request as ready for review
October 9, 2026 09:03
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
nicohrubec
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #24903 a span's end time is its start time plus the
performance.now()duration, which can differ from atimestampInSeconds()value taken mid-span by fractions of a microsecond in either direction. Basically because a double can't reliably hold the very minimal time difference here. This PR relaxes the test assertion a bit while still asserting that the span ended at the current time.