Repository navigation
fix(v10/effect): Detect HTTP spans named after the request method - #25169
Merged
Merged
Conversation
JPeer264
marked this pull request as ready for review
October 8, 2026 10:26
JPeer264
requested review from
msonnb,
nicohrubec and
s1gr1d
and removed request for
a team and
s1gr1d
October 8, 2026 10:26
msonnb
approved these changes
Oct 8, 2026
JPeer264
enabled auto-merge (squash)
October 8, 2026 10:39
Contributor
size-limit report 📦
|
49 of 50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25159
Differences to the original PR
packages/effect/src/tracer.ts: v10 sets no span op, only the origin. The method and kind check goes intoderiveOrigin, so on v10 the fix brings back theauto.http.effectorigin but adds nohttp.server/http.clientop.packages/effect/test/tracer.test.ts: the 3 new cases use the v10 test style. The case for aGETspan with no kind expectsauto.function.effect, the v10 default origin, instead of no origin and no op.effect-4-node/tests/spans.test.ts. The span name change fromhttp.server GETtoGETgoes intotransactions.test.ts.