Repository navigation
fix(core): Exclude attachments from internal exception events - #25160
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
msonnb
force-pushed
the
ms/internal-event-attachments
branch
from
October 8, 2026 08:45
3b90ace to
f948f1a
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f948f1a. Configure here.
msonnb
marked this pull request as ready for review
October 8, 2026 08:57
Lms24
approved these changes
Oct 8, 2026
chargome
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal exception events skip event processors and
beforeSendto prevent recursion, so they must also omit attachments that those callbacks would normally filter. Exclude attachments when building internal event envelopes, including attachments added by send hooks, while preserving ordinary event attachments and scope state.Fixes JS-2136.