Sitelet https://github.com/getsentry/sentry-elixir/pull/1066
Skip to content

fix(test): handle deduped events when collecting - #1066

Merged
solnic merged 3 commits into
masterfrom
1065-message-events-no-longer-deduped
May 21, 2026
Merged

solnic merged 3 commits into
masterfrom
1065-message-events-no-longer-deduped

Conversation

@solnic

@solnic solnic commented May 20, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes a regression in Sentry.Test that was introduced in 13.0.0 where duped events would be collected even when dedup_events: true was set.

Another thing that this addresses is adding nimble_ownership as a regular dep (not only in test env) - which is something that was reported in the comment thread under the issue.

Closes #1065

@solnic solnic linked an issue May 20, 2026 that may be closed by this pull request
@solnic
solnic force-pushed the 1065-message-events-no-longer-deduped branch from 7b3c1b1 to 8f7e309 Compare May 20, 2026 19:45
@solnic solnic changed the title 1065 message events no longer deduped fix(test): handle deduped events when collecting May 20, 2026
@solnic
solnic force-pushed the 1065-message-events-no-longer-deduped branch 3 times, most recently from a5b1261 to d783da3 Compare May 20, 2026 19:54
@solnic
solnic marked this pull request as ready for review May 20, 2026 19:56
@solnic
solnic marked this pull request as draft May 21, 2026 07:12
@solnic
solnic force-pushed the 1065-message-events-no-longer-deduped branch 2 times, most recently from 5fd1620 to d9d6255 Compare May 21, 2026 07:53
@solnic
solnic force-pushed the 1065-message-events-no-longer-deduped branch from d9d6255 to 6869af0 Compare May 21, 2026 07:57
@michallepicki

michallepicki commented May 21, 2026 •

Copy link
Copy Markdown
Contributor

I don't think nimble_ownership needs to be a regular dep if it's only used in Sentry.Test code. Following that logic would bypass also become a regular dep now? I don't want to have to ship cowboy in my bandit based Phoenix project :)

Instead, if start_collecting_sentry_reports is going to be still supported, I would suggest adding the same helpful runtime errors to it that setup_sentry has, basically this line to improve DX

@solnic

solnic commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

I don't think nimble_ownership needs to be a regular dep if it's only used in Sentry.Test code

I 100% agree - unfortunately this is how it used to be in pre-13.0.0 releases and because I added it back, the dep needs to be back too, otherwise it'd be a breaking change and I'd have to release 14.0.0 already 😢

Following that logic would bypass also become a regular dep now? I don't want to have to ship cowboy in my bandit based Phoenix project :)

Nope. We happen to use bypass but it's going away in 14.0.0 in favor of a new built-in abstraction (possibly a test transport or maybe just a test http client that captures requests for assertions, not sure yet).

Instead, if start_collecting_sentry_reports is going to be still supported, I would suggest adding the same helpful runtime errors to it that setup_sentry has, basically this line to improve DX

Thank you. This crossed my mind but then I realized that, as I explained above, sticking to only: [:test] would be a breaking change. Existing test suites that use 13.0.0 must continue to work when upgrading to 13.1.0.

@solnic
solnic marked this pull request as ready for review May 21, 2026 08:41
@dingsdax
dingsdax self-requested a review May 21, 2026 08:45
@solnic
solnic merged commit 01f8f19 into master May 21, 2026
13 checks passed
@solnic
solnic deleted the 1065-message-events-no-longer-deduped branch May 21, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message events no longer deduped

3 participants