You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(test): handle deduped events when collecting - #1066
Fixes a regression in Sentry.Test that was introduced in 13.0.0 where duped events would be collected even when dedup_events: true was set.
Another thing that this addresses is adding nimble_ownership as a regular dep (not only in test env) - which is something that was reported in the comment thread under the issue.
I don't think nimble_ownership needs to be a regular dep if it's only used in Sentry.Test code. Following that logic would bypass also become a regular dep now? I don't want to have to ship cowboy in my bandit based Phoenix project :)
Instead, if start_collecting_sentry_reports is going to be still supported, I would suggest adding the same helpful runtime errors to it that setup_sentry has, basically this line to improve DX
I don't think nimble_ownership needs to be a regular dep if it's only used in Sentry.Test code
I 100% agree - unfortunately this is how it used to be in pre-13.0.0 releases and because I added it back, the dep needs to be back too, otherwise it'd be a breaking change and I'd have to release 14.0.0 already 😢
Following that logic would bypass also become a regular dep now? I don't want to have to ship cowboy in my bandit based Phoenix project :)
Nope. We happen to use bypass but it's going away in 14.0.0 in favor of a new built-in abstraction (possibly a test transport or maybe just a test http client that captures requests for assertions, not sure yet).
Instead, if start_collecting_sentry_reports is going to be still supported, I would suggest adding the same helpful runtime errors to it that setup_sentry has, basically this line to improve DX
Thank you. This crossed my mind but then I realized that, as I explained above, sticking to only: [:test] would be a breaking change. Existing test suites that use 13.0.0 must continue to work when upgrading to 13.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression in
Sentry.Testthat was introduced in 13.0.0 where duped events would be collected even whendedup_events: truewas set.Another thing that this addresses is adding
nimble_ownershipas a regular dep (not only intestenv) - which is something that was reported in the comment thread under the issue.Closes #1065