Sitelet https://github.com/fsprojects/Paket/pull/768/files
Skip to content

Target framework: Added >= and made warnings more clear #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 3 commits into from
Apr 10, 2015
Merged

Target framework: Added >= and made warnings more clear #768

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34371b0
Target framework: Added >= and made warnings more clear
Thorium Apr 10, 2015
dd1f050
better warning handling
Thorium Apr 10, 2015
0c1c37f
Merge branch 'master' of https://github.com/fsprojects/Paket
Thorium Apr 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions src/Paket.Core/NugetConvert.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ module NugetEnv =
Packages = [for node in doc.SelectNodes("//package") ->
{ Id = node.Attributes.["id"].Value
Version = node.Attributes.["version"].Value |> SemVer.Parse
TargetFramework = node |> getAttribute "targetFramework" } ]}
TargetFramework =
node |> getAttribute "targetFramework" |> Option.map (fun t -> ">= " + t) } ]}

@theimowski theimowski Apr 10, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is actually the only change necessary? i.e. we don't need to call the optimizeRestrictions function?

@Thorium Thorium Apr 10, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think the optimization happens later anyways. :-)

|> ok
with _ -> fail (NugetPackagesConfigParseError file)

Expand Down Expand Up @@ -228,24 +229,31 @@ let createPackageRequirement (packageName, version, restrictions) sources depend
let createDependenciesFileR (rootDirectory : DirectoryInfo) nugetEnv mode =

let dependenciesFileName = Path.Combine(rootDirectory.FullName, Constants.DependenciesFileName)

let allVersions =

let allVersionsGroupped =
nugetEnv.NugetProjectFiles
|> Seq.collect (fun (_,c) -> c.Packages)
|> Seq.groupBy (fun p -> p.Id)
|> Seq.map (fun (name, packages) -> name, packages |> Seq.map (fun p -> p.Version, p.TargetFramework) |> Seq.distinct)

let findDistinctsPackages selector =
allVersionsGroupped
|> Seq.map (fun (name, packages) -> name, packages |> selector)
|> Seq.sortBy (fun (name,_) -> name.ToLower())

for (name, versions) in allVersions do
if Seq.length versions > 1
then traceWarnfn
"Package %s is referenced multiple times with different versions or target frameworks : %A. Paket will choose the latest version and disregard target framework."
name
(versions |> Seq.map string |> Seq.toList)

let findWarnings searchBy message =
for (name, versions) in
findDistinctsPackages searchBy
do
if Seq.length versions > 1
then traceWarnfn message name (versions |> Seq.toList)

findWarnings (Seq.map (fun p -> p.Version) >> Seq.distinct >> Seq.map string)
"Package %s is referenced multiple times in different versions: %A. Paket will choose the latest one."
findWarnings (Seq.map (fun p -> p.TargetFramework) >> Seq.distinct >> Seq.choose(fun target -> target) >> Seq.map string)
"Package %s is referenced multiple times with different target frameworks : %A. Paket may disregard target framework."

let latestVersions =
allVersions
findDistinctsPackages (Seq.map (fun p -> p.Version, p.TargetFramework) >> Seq.distinct)
|> Seq.map (fun (name, versions) ->
let latestVersion, _ = versions |> Seq.maxBy fst
let restrictions =
Expand Down