Sitelet https://github.com/fsprojects/Paket/pull/3764
Skip to content

bugfix/issue #3763 partially extracted nugets - #3764

Merged
forki merged 2 commits into
fsprojects:masterfrom
viktor-svub:bugfix/issue-3763
Dec 22, 2019
Merged

forki merged 2 commits into
fsprojects:masterfrom
viktor-svub:bugfix/issue-3763

Conversation

@viktor-svub

Copy link
Copy Markdown
Contributor

fixing partial nuget extraction #3763 by extending fixes for borked and leaky zips to catch more cases

@forki
forki requested a review from matthid December 22, 2019 07:07
@forki
forki merged commit 7e6289e into fsprojects:master Dec 22, 2019
@forki

forki commented Dec 22, 2019

Copy link
Copy Markdown
Member

This is released in v6 alpha channel. Can you please test it out and then I'll push it to v5 as well. Thanks for your help!

@viktor-svub

Copy link
Copy Markdown
Contributor Author

Verified 6.0.0-alpha009 with previously failing dependencies -- the expected yellow warning "Trying to extract files individually" shows up, and the packages are fully extracted and work correctly in dotnet restore/build/run. Thank you!

@viktor-svub

Copy link
Copy Markdown
Contributor Author

It seems version 5.241.3 has some new merge/build issue -- paket install ends with:

Paket failed with
-> Resource stream 'Paket.Restore.targets' could not be found in the Paket.Core assembly

It happens on all install attempts, regardless of .paket\Paket.Restore.targets presence, and the file indeed does not re/appear with this version when not present.

It does not happen when 6.0.0-alpha009 is used for install, regardless if fresh or using 5.241.3 bootstrapper with version in paket.dependencies to use the alpha.

@forki

forki commented Dec 22, 2019 via email

Copy link
Copy Markdown
Member

@forki

forki commented Dec 22, 2019

Copy link
Copy Markdown
Member

Ok never mind. It's still broken. Seems I need to dig deeper tomorrow.

@forki

forki commented Dec 22, 2019

Copy link
Copy Markdown
Member

ok released 5.241.5 and that one seems to work. I had to install VS 2019 because it used a wrong compiler version. ffs

@viktor-svub

Copy link
Copy Markdown
Contributor Author

thank you! 5.241.5 works perfectly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants