Sitelet https://github.com/fsprojects/Paket/pull/2489
Skip to content

Add default NuGet source back to find-packages - #2489

Merged
forki merged 1 commit into
fsprojects:masterfrom
agross:find-packages-default-source
Jul 6, 2017
Merged

forki merged 1 commit into
fsprojects:masterfrom
agross:find-packages-default-source

Conversation

@agross

@agross agross commented Jul 5, 2017 •

Copy link
Copy Markdown
Contributor

As noted by @fsoikin in aa5f1b7#commitcomment-22938166 I unintentionally removed the default NuGet source. Thanks for the heads-up, @fsoikin!

We should probably release 5.4.6 such that Paket doesn't stay broken until 5.5-alpha is released. I apologize for the trouble!

@forki
forki merged commit 9cad66a into fsprojects:master Jul 6, 2017
@forki

forki commented Jul 6, 2017

Copy link
Copy Markdown
Member

ok released as hotfix and in alpha channel. Thx

@fsoikin

fsoikin commented Jul 6, 2017

Copy link
Copy Markdown
Contributor

Since find-packages has a default source prepended, should find-package-versions be the same? In fact, perhaps it makes sense to factor out the common code from them both? Common sense would suggest that these two commands ought to use the same package-finding logic.

@agross
agross deleted the find-packages-default-source branch July 6, 2017 21:36
@agross

agross commented Jul 6, 2017

Copy link
Copy Markdown
Contributor Author

@fsoikin This sounds useful! I never considered the case, I was recently more concerned about the command line in general :)

@fsoikin

fsoikin commented Jul 6, 2017

Copy link
Copy Markdown
Contributor

Ok, I'll send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants