make ListTemplateFiles more robust - #1209
Merged
Merged
Conversation
krgn
force-pushed
the
prevent-crash-TemplateFile-load
branch
from
November 10, 2015 21:36
871e873 to
9d94484
Compare
forki
added a commit
that referenced
this pull request
Nov 11, 2015
make ListTemplateFiles more robust
Member
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A TemplateFile may not be loadable if some of the referenced files are not available (e.g. the Paket.PowerShell project and its dependencies on Linux) and thus renders the method useless in these scenarios.
I refined the loading process to skip TemplateFiles that crash on Load.