fix: remove space from artifact - #187

✅ Approve — automated review

The archive template and installer now consistently use artifact names without the unintended space.

No findings.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.10%. Comparing base (bb6f941) to head (e735d82).

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   72.10%   72.10%           
=======================================
  Files          60       60           
  Lines        5621     5621           
=======================================
  Hits         4053     4053           
  Misses       1341     1341           
  Partials      227      227           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

This PR fixes a real bug in the release artifact naming: the folded (>-) name_template in .goreleaser.yaml was folding the newline after {{ .ProjectName }}_ into a literal space, producing archives named numscript_ 0.0.18_... while install.sh looked for numscript_0.0.18_..., so the installer could never find a release. Collapsing the template to a single line restores the match, and I verified the resulting names align with install.sh for every build matrix combination (linux/amd64 → Linux_x86_64.tar.gz, darwin/arm64 → Darwin_arm64.tar.gz, windows/amd64 → Windows_x86_64.zip, consistent with the zip format_overrides). The ${LATEST_TAG#v} expansion in the rewritten FILENAME is valid bash and correct. Overall recommendation: approve.

Standards

• [Low] Duplicated artifact-name contract between .goreleaser.yaml and install.sh — .goreleaser.yaml:34 encodes the release naming scheme (ProjectName_Version_TitleOs_Arch with the amd64→x86_64 mapping) and install.sh:41 independently reconstructs the same scheme (numscript_${LATEST_TAG#v}_${PLATFORM}_${ARCH}.${EXT}), including a second copy of the arch mapping at install.sh:18-20. There is no single source of truth, so any rename in one place silently desynchronizes the other and breaks the installer — which is exactly the failure mode this PR corrects. Since no shared definition is practical across a GoReleaser template and a shell script, at minimum document the invariant (e.g. a comment on both sides noting they must be kept in lockstep). Judgement call, not a blocking issue.

No documented-standard violations: the only standards document (CONTRIBUTING.md) covers snapshot updates and parser regeneration, neither of which this diff touches.

Spec

No spec is available for this change, so no spec review was performed; no confirmed material finding.

Reviewed independently by GLM (glm-5.3-flash) and DeepSeek (deepseek-v4-pro-0813) via Shipfox; verified and synthesized by GLM.