Add non persistant toggle float - #307

p1gp1g, It still doesn't fix the problem that you would have to have 5 different keybindings for toggling float, i came up with a better way to handle it, the thing is if someone is willing to work on it.

#292

Sorry, I think something has been confusing. Why would you need 5 different keybindings ? Isn't this PR implementing what you talked about in #292 ?

Currently, there are 2 keybindings:

1. One to permanently float window based on its class name
2. One to permanently float window based on its class name + its title.

None of them can be used to temporarily float a single window. For instance, I use it a lot to take screenshots of windows. + Using those 2 previous keybindings to temporarily toggle a window can have side effects like floating other windows, or override some rules (which is annoying).

This PR adds a keybinding to add a floating rule based on the window ID.

PS: Sorry If I was not very clear in a first time :). Or do I miss something ?

Hi @p1gp1g and @RyanOrigens

I tested this quite a bit. I think the Super + c should be using the window.id instead of the window.title to temporarily float the window. But it should only be saved in memory and not on the windows.json config. If you want it to be permanent, press the Super + Shift + c and stores it by window.wmclass.

For #292 - I do not know how to do timing by keypresses.

For my original workflow, Super + c was to maintain focus on the window and bringing it front and center temporarily. I got that from Magnet (Mac) but I did not like a very tall window nor a very wide one but just enough percentage of the screen size. I also intended the percentages to be configurable but I had to ship it.

With that said, I think maintaining only 2 shortcuts to float things: temporary and permanent would be optimal and much simpler.

Oh and before I forget, the window.id is a sequential number if that gets into windows.json - it will fill it up very fast without a way to remove the unused ones unless implemented in the PR.

Oh and before I forget, the window.id is a sequential number if that gets into windows.json - it will fill it up very fast without a way to remove the unused ones unless implemented in the PR.

This is the reason for this change : https://github.com/forge-ext/forge/pull/307/files#diff-ecc5aba1b19feb12aedd8037846a95297082072be1a704814195edb468f846dfR71-R73

When you start your session, it will load the floating rules and filter out the ones with wmId, so when you will toggle anything during this session it will remove the old ones. That is not perfect and not writing at all may be implemented but it does have to be in this PR (to reduce the PR size, and because something is already in place to avoid ever growing windows.json)

PS: Sorry for the missclick that have closed the PR right before

With that said, I think maintaining only 2 shortcuts to float things: temporary and permanent would be optimal and much simpler.

I'm pretty OK with this. I can edit that PR if you want. Should the permanent one includes the wmTitle or not ?

@p1gp1g - the permanent one should include the wm_class only

@jmmaranan : I've set the non-persistent behavior to window-toggle-float. window-toggle-always-float does not use wmId but wmTitle.

I've suggested a small change to make it cleaner if you want.

@ p1gp1g - the permanent one should include the wm_class only

Done with 99e1cb8