Sitelet https://github.com/flutter/packages/pull/13081
Skip to content

[camera_android_camerax] Add magic number guideline to TESTING.md - #13081

Open
camsim99 wants to merge 1 commit into
flutter:mainfrom
camsim99:pos_magicnos
Open

camsim99 wants to merge 1 commit into
flutter:mainfrom
camsim99:pos_magicnos

Conversation

@camsim99

@camsim99 camsim99 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

To improve agent-author test clarity, adds testing guidance for agents regarding asserting against number literal without explanation or instead of a variable unnecessarily.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TESTING.md file in the camera_android_camerax package to add a 'General Guidelines' section, which advises against using magic numbers in assertions. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant