Repository navigation
[material_ui] Port flutter/flutter #185475 "Accessibility: Add semanticLabel to MenuAnchor" - #12806
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a semanticLabel property to the MenuAnchor widget, wrapping the expanded menu overlay in a Semantics widget when a label is provided. A corresponding test case and example update are also included. The review feedback recommends setting explicitChildNodes: true on the Semantics widget to ensure child menu items are treated as separate interactive nodes in the semantics tree.
9 of 10 tasks
navaronbracke
approved these changes
Sep 11, 2026
This was referenced Sep 14, 2026
dkwingsmt
pushed a commit
to dkwingsmt/flutter
that referenced
this pull request
Sep 15, 2026
…r#192809) flutter/packages@9caa77c...bebbb57 2026-09-15 5684363+tenninebt@users.noreply.github.com [google_maps_flutter_platform_interface] Add onPointOfInterestTap support (flutter/packages#12752) 2026-09-14 stuartmorgan@google.com [google_maps_flutter] Adopts new async/await Swift Pigeon support (flutter/packages#12860) 2026-09-14 109692895+Massinissa-Mouhoub@users.noreply.github.com [material_ui] Fix `todayBorder` color being overridden by `todayForegroundColor` in `YearPicker` (flutter/packages#12697) 2026-09-13 engine-flutter-autoroll@skia.org Roll Flutter from 2553f89 to 8b3e8f5 (4 revisions) (flutter/packages#12856) 2026-09-12 stuartmorgan@google.com [google_maps_flutter] Convert remaining code to Swift (flutter/packages#12768) 2026-09-12 engine-flutter-autoroll@skia.org Roll Flutter from 63b9518 to 2553f89 (62 revisions) (flutter/packages#12855) 2026-09-12 engine-flutter-autoroll@skia.org Roll Flutter (stable) from d3b14c8 to 9584c67 (15 revisions) (flutter/packages#12854) 2026-09-12 36861262+QuncCccccc@users.noreply.github.com [material_ui] Update gen_defaults color helper (flutter/packages#12846) 2026-09-11 brunocorona.alcantar@gmail.com [material_ui] Port flutter/flutter flutter#185475 "Accessibility: Add semanticLabel to MenuAnchor" (flutter/packages#12806) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports flutter/flutter#185475 to
material_ui, following the instructions in flutter/flutter#188444. The commits were cherry-picked from the original PR, with only file paths adjusted for this repo.MenuAnchorhad no way to label the expanded menu overlay, so screen readers announced nothing useful when a menu opened. This adds asemanticLabelproperty, applied to aSemanticsnode wrapping the submenu in_buildOverlay, and only when a label is provided.The original PR also announced the label with
SemanticsService.announcewhen the menu opened. Following @chunhtai's review feedback on flutter/flutter#185475, that part is dropped here: a semantics label should not double as announcement text, and anyone who wants an announcement can callSemanticsService.announcefromonOpen. The last commit on this branch removes it.Tests
New test
MenuAnchor applies semanticLabel to the expanded menu overlayinpackages/material_ui/test/menu_anchor_test.dart, checking that the label is absent before the menu opens and present once it expands. Themenu_anchor.0API example now sets asemanticLabel, and its example test still passes.Fixes flutter/flutter#184876
Supersedes flutter/flutter#185475, which will be closed with a pointer to this PR.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2