Repository navigation
[camera_android_camerax] Fix exposure offset setting error thrown when canceled by a new request - #12580
Closed
camsim99 wants to merge 2 commits into
Closed
[camera_android_camerax] Fix exposure offset setting error thrown when canceled by a new request#12580camsim99 wants to merge 2 commits into
camsim99 wants to merge 2 commits into
Conversation
…st in camera_android_camerax
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the .agents directory, including all agent skills, guides, playbooks, and evaluation configurations. Additionally, it updates the camera_android_camerax package to version 0.7.4+7, modifying setExposureOffset in AndroidCameraCameraX to return the input offset instead of throwing a CameraException when the exposure compensation index update is canceled. The corresponding unit tests in android_camera_camerax_test.dart and the package CHANGELOG.md have been updated to reflect this change. There are no review comments to address, so no further feedback is provided.
camsim99
marked this pull request as draft
August 24, 2026 19:31
11 tasks done
auto-submit Bot
pushed a commit
that referenced
this pull request
Sep 30, 2026
…n canceled by a new request (#12582) When setting exposure offset is canceled (caused by a user submitting too many requests or the camera closing) return the rounded exposure offset instead of throwing an error, causing the app to crash. Fixes flutter/flutter#148521. ____ Project One Shot Demonstration. Implementation plan used to execute this one shot: 781681d Related (attempt without harness): #12580 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not land. Agent authored PR + description. For demonstration purposes only.
Lesson learned from this : we should add cognitive complexity check to pre-push skill.
AI generated description:
Fixes an issue (flutter/flutter#148521) where
setExposureOffsetthrows aCameraExceptionand sends an error to the error stream when the request is canceled by a new request. This prevents the camera preview from freezing when setting the exposure offset rapidly. Also fixes the returned offset value which was incorrectly returning the index.