Sitelet https://github.com/flutter/packages/pull/12543
Skip to content

[camera_android_camerax] Migrate from dart_skills_lint to skills_lint - #12543

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
reidbaker-agent:migrate-to-skills-lint-dot-dart
Aug 24, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
reidbaker-agent:migrate-to-skills-lint-dot-dart

Conversation

@reidbaker-agent

@reidbaker-agent reidbaker-agent commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

The skills_lint code is moving out of flutter/agent-plugins to its own github repo skills_lint.dart.
-@reidbaker


Relevant prompts

ok our task today is to migrate (and document how to migrate) the use of dart_skills_lint in the package repo to skills_lint.dart. 

Feel free to ask me questions  

Agent authored description
Migrates camera_android_camerax from the legacy dart_skills_lint dependency to skills_lint from google/skills_lint.dart pinned to commit hash e6e695e1550f81342fe5acd4dbe65040b5aa44c3.

  • Renames dart_skills_lint.yaml to skills_lint.yaml and updates root key to skills_lint:.
  • Updates Dart imports in test/validate_skills_test.dart and test/enforce_tracked_skills_prevent_publishing_rule.dart to package:skills_lint/skills_lint.dart.
  • Updates diagnostic messages and skill documentation references.

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
  • I read the Tree Hygiene page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter.
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I updated/added any relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

@reidbaker
reidbaker self-requested a review August 21, 2026 21:03
@reidbaker reidbaker added the CICD Run CI/CD label Aug 21, 2026
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Aug 21, 2026
@reidbaker reidbaker added the CICD Run CI/CD label Aug 24, 2026
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Aug 24, 2026
@reidbaker reidbaker added the CICD Run CI/CD label Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOPE! This is not a public facing change and should not have a changelog.

repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.7.4+6
version: 0.7.4+7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOPE!

@reidbaker
reidbaker marked this pull request as ready for review August 24, 2026 18:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the skills validation tooling from dart_skills_lint to skills_lint across the camera_android_camerax package. The changes include updating the allowed dependencies in .repo_tool_config.yaml, modifying the pubspec.yaml and skills_lint.yaml configuration files, updating references in documentation and test files, and bumping the package version to 0.7.4+7. There are no review comments, and I have no feedback to provide.

@reidbaker
reidbaker force-pushed the migrate-to-skills-lint-dot-dart branch from 9292a9b to a5f3260 Compare August 24, 2026 18:21
@reidbaker-agent

This comment was marked as low quality.

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Aug 24, 2026
@reidbaker reidbaker added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes CICD Run CI/CD labels Aug 24, 2026
@reidbaker
reidbaker requested a review from camsim99 August 24, 2026 19:26

@camsim99 camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2026
@auto-submit
auto-submit Bot merged commit 90ba788 into flutter:main Aug 24, 2026
14 checks passed
zijiehe-google-com pushed a commit to zijiehe-google-com/flutter that referenced this pull request Aug 25, 2026
…er#191734)

flutter/packages@df2ba94...740f093

2026-08-25 srawlins@google.com [cupertino_ui] Remove unused parameters
from constructors of generic classes. (flutter/packages#12457)
2026-08-25 srawlins@google.com [material_ui] Remove unused parameters
from constructors of generic classes. (flutter/packages#12458)
2026-08-25 6655696+guidezpl@users.noreply.github.com Ignore shared code
for iOS platform implementation of Google Maps plugin
(flutter/packages#12529)
2026-08-25 136096126+glitchfl@users.noreply.github.com [cross_file]
fixed `readAsString` decoding in-memory bytes as UTF-16
(flutter/packages#12479)
2026-08-25 lozhkovoi@gmail.com [cupertino_ui] Remove two items assert to
allow CupertinoTabBar to have one tab (flutter/packages#12546)
2026-08-25 huahua8893@sina.cn [cupertino_ui] Fix covered sheet revealing
root route through top gap (flutter/packages#12530)
2026-08-25 fluttergithubbot@gmail.com Sync release-go_router-18.0.0 to
main (flutter/packages#12575)
2026-08-25 fluttergithubbot@gmail.com Sync release-material_ui-1.1.0 to
main (flutter/packages#12577)
2026-08-25 fluttergithubbot@gmail.com Sync release-cupertino_ui-1.0.1 to
main (flutter/packages#12576)
2026-08-24 41930132+hellohuanlin@users.noreply.github.com
[quick_actions_ios]unskip XCUITests (flutter/packages#12436)
2026-08-24 karthimanikuttan001@gmail.com Fix RangeSlider thumb overlay
remains visible after touch interaction ends (flutter/packages#12560)
2026-08-24 victor.orozco@cloudsufi.com [google_sign_in] Increase iOS
coverage tests (flutter/packages#12484)
2026-08-24 269567208+reidbaker-agent@users.noreply.github.com
[camera_android_camerax] Migrate from dart_skills_lint to skills_lint
(flutter/packages#12543)
2026-08-24 74037732+developerashkan@users.noreply.github.com [go_router]
Clarify onEnter/redirect ordering, add regression test
(flutter/packages#12337)
2026-08-24 brunocorona.alcantar@gmail.com [material_ui] Port
flutter/flutter flutter#185149 "Slider label clips the screen"
(flutter/packages#12572)
2026-08-24 engine-flutter-autoroll@skia.org Roll Flutter from
65c9a8d to 9a82789 (17 revisions) (flutter/packages#12578)
2026-08-24 stuartmorgan@google.com [tool] Fix dart_test.yaml parsing
(flutter/packages#12574)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jagadeesh8682 pushed a commit to jagadeesh8682/packages that referenced this pull request Sep 2, 2026
…flutter#12543)

The skills_lint code is moving out of flutter/agent-plugins to its own github repo skills_lint.dart. 
-@reidbaker

---
Relevant prompts 
```
ok our task today is to migrate (and document how to migrate) the use of dart_skills_lint in the package repo to skills_lint.dart. 

Feel free to ask me questions  
```
---
Agent authored description 
Migrates `camera_android_camerax` from the legacy `dart_skills_lint` dependency to `skills_lint` from `google/skills_lint.dart` pinned to commit hash `e6e695e1550f81342fe5acd4dbe65040b5aa44c3`.

- Renames `dart_skills_lint.yaml` to `skills_lint.yaml` and updates root key to `skills_lint:`.
- Updates Dart imports in `test/validate_skills_test.dart` and `test/enforce_tracked_skills_prevent_publishing_rule.dart` to `package:skills_lint/skills_lint.dart`.
- Updates diagnostic messages and skill documentation references.

## Pre-Review Checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants