Sitelet https://github.com/flutter/packages/pull/12460
Skip to content

[material_ui] Use super parameters in more places - #12460

Merged
srawlins merged 6 commits into
flutter:mainfrom
srawlins:use-super-mat
Sep 2, 2026
Merged

srawlins merged 6 commits into
flutter:mainfrom
srawlins:use-super-mat

Conversation

@srawlins

Copy link
Copy Markdown
Contributor

This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.

Pre-Review Checklist

Test exempt, as this code is covered by existing static and runtime checks.

This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't previously
report these cases. But they will be reported soon.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 13, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors constructors in several files, including drawer.dart, dropdown_menu_form_field.dart, input_decorator.dart, and will_pop_test.dart, to use Dart's super-initializer parameters instead of manually passing arguments to the super constructor. There are no review comments, and I have no feedback to provide.

@Piinks Piinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026
@dkwingsmt
dkwingsmt requested a review from elliette August 19, 2026 18:35
@elliette elliette added the override: no versioning needed Override the check requiring version bumps for most changes label Aug 21, 2026
@elliette

Copy link
Copy Markdown
Member

@elliette elliette removed the override: no versioning needed Override the check requiring version bumps for most changes label Aug 21, 2026
Comment thread packages/material_ui/CHANGELOG.md
@srawlins
srawlins merged commit 955fd5d into flutter:main Sep 2, 2026
11 of 13 checks passed
@srawlins
srawlins deleted the use-super-mat branch September 2, 2026 02:56
pull Bot pushed a commit to Mu-L/flutter that referenced this pull request Sep 2, 2026
…r#192191)

flutter/packages@7a7912f...18fe786

2026-09-02 32538273+ValentinVignal@users.noreply.github.com
[path_parsing] Fix deprecation lints (flutter/packages#12704)
2026-09-02 srawlins@google.com [material_ui] Use super parameters in
more places (flutter/packages#12460)
2026-09-02 21270878+elliette@users.noreply.github.com [material_ui] Add
a README and placeholders for migrating gen_defaults templates
(flutter/packages#12714)
2026-09-01 victor.orozco@cloudsufi.com [image_picker] Add native tests
for image, metadata, photo-asset, and PHPicker save utilities
(flutter/packages#12536)
2026-09-01 lozhkovoi@gmail.com [material_ui] Port routes_transition_test
to material_ui (flutter/packages#12634)
2026-09-01 engine-flutter-autoroll@skia.org Roll Flutter from
c8c5e3b to 0cbd1a4 (23 revisions) (flutter/packages#12712)
2026-09-01 32538273+ValentinVignal@users.noreply.github.com
[material_ui] Remove !chrome in text_field_test.dart
(flutter/packages#12548)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dkwingsmt pushed a commit to srawlins/flutter that referenced this pull request Sep 9, 2026
This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.

Changes landed "upstream" at flutter/packages#12460
pull Bot pushed a commit to safarmer/flutter that referenced this pull request Sep 9, 2026
This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't
previously report these cases. But they will be reported soon.

Changes landed "upstream" at
flutter/packages#12460


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't
previously report these cases. But they will be reported soon.


## Pre-Review Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran [the
auto-formatter].
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I followed [the version and CHANGELOG instructions], using
[semantic versioning] and the [repository CHANGELOG style], or I have
commented below to indicate which documented exception this PR falls
under[^1].
- [x] I updated/added any relevant documentation (doc comments with
`///`).
- [x] I added new tests to check the change I am making, or I have
commented below to indicate which [test exemption] this PR falls
under[^1].
- [x] All existing and new tests are passing.

Test exempt, as this code is covered by existing static and runtime
checks.


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[the auto-formatter]:
https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[the version and CHANGELOG instructions]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates
[semantic versioning]:
https://dart.dev/tools/pub/versioning#semantic-versions
[repository CHANGELOG style]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[test exemption]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't
previously report these cases. But they will be reported soon.


## Pre-Review Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran [the
auto-formatter].
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I followed [the version and CHANGELOG instructions], using
[semantic versioning] and the [repository CHANGELOG style], or I have
commented below to indicate which documented exception this PR falls
under[^1].
- [x] I updated/added any relevant documentation (doc comments with
`///`).
- [x] I added new tests to check the change I am making, or I have
commented below to indicate which [test exemption] this PR falls
under[^1].
- [x] All existing and new tests are passing.

Test exempt, as this code is covered by existing static and runtime
checks.


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[the auto-formatter]:
https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[the version and CHANGELOG instructions]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates
[semantic versioning]:
https://dart.dev/tools/pub/versioning#semantic-versions
[repository CHANGELOG style]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[test exemption]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants