Repository navigation
[tool] Enforce README package table order - #12316
Merged
auto-submit[bot] merged 4 commits intoOct 1, 2026
Merged
auto-submit[bot] merged 4 commits into
auto-submit[bot] merged 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds validation to ensure that the package table in the root README.md is sorted alphabetically. It updates RepoInfoValidator to track the alphabetical order of entries, introduces a new exit code for unsorted tables, and adds a corresponding unit test to verify this behavior. The root README.md table is also updated to be sorted alphabetically. There are no review comments, so no additional feedback is provided.
stuartmorgan-g
self-requested a review
August 11, 2026 18:56
Contributor
|
Friendly ping for @stuartmorgan-g |
stuartmorgan-g
approved these changes
Sep 9, 2026
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, sorry for the delay here as well!
@tarrinneal for secondary review
tarrinneal
approved these changes
Sep 30, 2026
tarrinneal
left a comment
Contributor
There was a problem hiding this comment.
Updated the changelog since my delays caused it to be behind. lgtm
Contributor
|
autosubmit label was removed for flutter/packages/12316, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
autosubmit label was removed for flutter/packages/12316, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jesswrd
pushed a commit
to jesswrd/flutter
that referenced
this pull request
Oct 1, 2026
…er#193641) flutter/packages@0ba9a82...d5ec6db 2026-10-01 faheemabbas766@gmail.com [tool] Enforce README package table order (flutter/packages#12316) 2026-09-30 jessiewong401@gmail.com [various] Allow plugin example apps to build and test on JDK 25 (flutter/packages#13031) 2026-09-30 149176071+m1roxx@users.noreply.github.com [go_router] Expose Navigator clipBehavior on ShellRoute and StatefulShellBranch (flutter/packages#12646) 2026-09-30 stuartmorgan@google.com [google_maps_flutter] Convert unit tests to Kotlin (flutter/packages#13072) 2026-09-30 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 ListTile template to use new gen_defaults (flutter/packages#13056) 2026-09-30 15619084+vashworth@users.noreply.github.com Allow tests to use macOS 15.7 or macOS 26.6 (flutter/packages#13007) 2026-09-30 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Fix exposure offset setting error thrown when canceled by a new request (flutter/packages#12582) 2026-09-30 engine-flutter-autoroll@skia.org Roll Flutter from 55b8f88 to d649d2b (27 revisions) (flutter/packages#13080) 2026-09-30 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 InputDecorator template to use new gen_defaults (flutter/packages#13024) 2026-09-30 tarrinneal@gmail.com [pigeon] Fix JNI/FFI typed data memory lifetime bugs and update docs (flutter/packages#13061) 2026-09-30 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Correct `pre-push` skill version validation logic (flutter/packages#12371) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds repository-info validation that rejects package rows in the root README when they are not sorted alphabetically. The error identifies the first out-of-order pair.
This also adds regression coverage and sorts the three existing out-of-order rows so the repository passes the new validation.
Fixes flutter/flutter#188727.
Pre-Review Checklist
[shared_preferences]///).The tool already has a
NEXTCHANGELOG section, so this change adds its release note there without changing the package version.Validation:
dart format --output=none --set-exit-if-changed lib/src/validators/repo_info_validator.dart test/validate_command_repo_info_test.dartdart analyze --fatal-infosdart test test/validate_command_repo_info_test.dart(29 tests)dart test(1,221 tests)If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2