Repository navigation
[material_ui] Add helper methods in gen_defaults template - #12121
Merged
QuncCccccc merged 2 commits intoJul 8, 2026
Merged
Conversation
QuncCccccc
marked this pull request as ready for review
July 6, 2026 21:56
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Material 3 component defaults generator by renaming the generated class suffixes and adding helper methods to generate Dart expressions for token numbers, colors, and shapes. It also updates the corresponding tests and test fixtures to cover these new capabilities. Review feedback suggests optimizing the colorWithOpacity helper to avoid redundant calls when opacity is 1.0, and correcting a minor formatting issue by adding a space after the comma in the generated BorderRadius.vertical expression and its corresponding test.
9 of 11 tasks
QuncCccccc
force-pushed
the
gen_defaults_template_helpers
branch
from
July 6, 2026 23:46
2978a75 to
e037015
Compare
10 tasks done
elliette
approved these changes
Jul 7, 2026
11 tasks done
auto-submit Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
Work towards flutter/flutter#191088 **Ports over #12121 which landed on the `m3e_migration` feature branch.** ### Original PR description Related to flutter/flutter#184950 This PR is to add some helper methods to handle color, and shape tokens. Also I updated the generated default class name from _M3xxx to _xxxM3 to keep the name consistent with the original M2 and M3 defaults. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
) Work towards flutter/flutter#191088 **Ports over flutter#12121 which landed on the `m3e_migration` feature branch.** ### Original PR description Related to flutter/flutter#184950 This PR is to add some helper methods to handle color, and shape tokens. Also I updated the generated default class name from _M3xxx to _xxxM3 to keep the name consistent with the original M2 and M3 defaults. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
) Work towards flutter/flutter#191088 **Ports over flutter#12121 which landed on the `m3e_migration` feature branch.** ### Original PR description Related to flutter/flutter#184950 This PR is to add some helper methods to handle color, and shape tokens. Also I updated the generated default class name from _M3xxx to _xxxM3 to keep the name consistent with the original M2 and M3 defaults. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to flutter/flutter#184950
This PR is to add some helper methods to handle color, and shape tokens. Also I updated the generated default class name from
_M3xxxto_xxxM3to keep the name consistent with the original M2 and M3 defaults.Pre-Review Checklist
[shared_preferences]///).