Sitelet https://github.com/flutter/flutter/pull/82733
Skip to content

[documentation] Fix AnimatedSize example - #82733

Closed
TahaTesser wants to merge 1 commit into
flutter:masterfrom
TahaTesser:fix_animated_size_example
Closed

[documentation] Fix AnimatedSize example#82733
TahaTesser wants to merge 1 commit into
flutter:masterfrom
TahaTesser:fix_animated_size_example

Conversation

@TahaTesser

@TahaTesser TahaTesser commented May 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

AnimatedSize example is missing vsync.

Go to https://api.flutter.dev/flutter/widgets/AnimatedSize-class.html

Modify the example to make it work, add vsync: this,

        child: AnimatedSize(
          vsync: this,
          curve: Curves.easeIn,
          duration: const Duration(seconds: 1),
          child: FlutterLogo(size: _size),
        ),

fixes #82619

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label May 17, 2021
@flutter-dashboard

flutter-dashboard Bot commented May 17, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label May 17, 2021
@TahaTesser TahaTesser changed the title [documentation][example] FIx AnimatedSize example [documentation] Fix AnimatedSize example May 17, 2021
@TahaTesser TahaTesser added the d: examples Sample code and demos label May 17, 2021
@TahaTesser
TahaTesser requested a review from Piinks May 17, 2021 20:05
Piinks
Piinks approved these changes May 17, 2021
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation labels May 17, 2021
@fluttergithubbot

fluttergithubbot commented May 17, 2021

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@TahaTesser

TahaTesser commented May 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Actually, vsync is deprecated now #81067
So the change is not required. looks like flutter API's dartpad hasn't received these changes even in master docs
https://master-api.flutter.dev/flutter/widgets/AnimatedSize-class.html

Closing

@TahaTesser TahaTesser closed this May 17, 2021
@TahaTesser
TahaTesser deleted the fix_animated_size_example branch May 17, 2021 21:00
@Piinks

Piinks commented May 17, 2021

Copy link
Copy Markdown
Contributor

Ooh. Yeah, I think this is because Dartpad only runs off of the stable channel.

@TahaTesser TahaTesser mentioned this pull request Jun 2, 2021
Merged
7 of 8 tasks
@TahaTesser TahaTesser mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AnimatedSize interactive sample not working

3 participants

@TahaTesser @fluttergithubbot @Piinks