Handle uncaught error for warnIfSlow - #56418
Merged
Merged
Conversation
jonahwilliams
approved these changes
May 6, 2020
jonahwilliams
left a comment
Contributor
There was a problem hiding this comment.
LGTM
This looks like a tricky bug, thank you for tracking it down.
Member
Author
|
No problem :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_warnIfSlowcreates a new future that resolves after a timeout duration.flutter/packages/flutter_driver/lib/src/driver/vmservice_driver.dart
Line 636 in 8568eda
This is a new future that is separate from the returned
future. If the originalfutureresolves with an error,future.timeoutwill also complete with an error that cannot be handled by callers of_warnIfSlow.This fixes the breakage of the recovery flow for health checks at
flutter/packages/flutter_driver/lib/src/driver/vmservice_driver.dart
Line 220 in 8568eda
Related Issues
None
Tests
I added the following tests:
Add a test to simulate a rpc failure.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.