[flutter_tools] reland remove flutter view cache - #56387
Merged
jonahwilliams merged 12 commits intoMay 5, 2020
Merged
Conversation
This reverts commit 8574cc7.
jonahwilliams
commented
May 5, 2020
| @visibleForTesting Duration timeoutDelay = const Duration(seconds: 10), | ||
| }) async { | ||
| if (!device.supportsFlutterExit) { | ||
| if (!device.supportsFlutterExit || vmService == null) { |
Contributor
Author
There was a problem hiding this comment.
This is the fix
jonahwilliams
commented
May 5, 2020
| expect(fakeVmServiceHost.hasRemainingExpectations, false); | ||
| })); | ||
|
|
||
| test('FlutterDevice can exit from a release mode isolate with no VmService', () => testbed.run(() async { |
Contributor
Author
There was a problem hiding this comment.
This is the test
Contributor
Author
|
NNBD when! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #56194
Remove caching of FlutterView and poll forever if the list of flutter views is empty.
Added test for missing release mode logic.