Sitelet https://github.com/flutter/flutter/pull/37735
Skip to content

Remove unused no-build flag from the flutter run command - #37735

Merged
jason-simmons merged 1 commit into
flutter:masterfrom
jason-simmons:run_remove_nobuild
Aug 7, 2019
Merged

jason-simmons merged 1 commit into
flutter:masterfrom
jason-simmons:run_remove_nobuild

Conversation

@jason-simmons

Copy link
Copy Markdown
Member

The use-application-binary flag can be used to run a previously built app package.

The use-application-binary flag can be used to run a previously built
app package.
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 6, 2019

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Aug 7, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #37735 into master will decrease coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37735      +/-   ##
==========================================
- Coverage   55.92%   55.06%   -0.87%     
==========================================
  Files         193      193              
  Lines       18172    18171       -1     
==========================================
- Hits        10163    10006     -157     
- Misses       8009     8165     +156
Flag Coverage Δ
#flutter_tool 55.06% <ø> (-0.87%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/run_hot.dart 69.04% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/run_cold.dart 19.75% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/commands/run.dart 60.09% <ø> (-0.2%) ⬇️
...ges/flutter_tools/lib/src/resident_web_runner.dart 69.59% <ø> (ø) ⬆️
...ackages/flutter_tools/lib/src/resident_runner.dart 53.93% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/compile.dart 11.49% <0%> (-65.86%) ⬇️
packages/flutter_tools/lib/src/context_runner.dart 66.66% <0%> (-1.97%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.73% <0%> (-1.96%) ⬇️
packages/flutter_tools/lib/src/cache.dart 41.99% <0%> (-0.73%) ⬇️
...r_tools/lib/src/runner/flutter_command_runner.dart 69.42% <0%> (+0.41%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeccd20...2aacceb. Read the comment docs.

@jason-simmons
jason-simmons merged commit 4f302dc into flutter:master Aug 7, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants