Sitelet https://github.com/flutter/flutter/pull/31262
Skip to content

Add track-widget-creation flag to attach command - #31262

Merged
keertip merged 2 commits into
flutter:masterfrom
keertip:attach
Apr 22, 2019
Merged

keertip merged 2 commits into
flutter:masterfrom
keertip:attach

Conversation

@keertip

@keertip keertip commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

Add an option for passing in the track-widget-creation flag to the attach command.

Internally the track-widget-creation will be enabled by default for all debug builds. As build and run are separate actions, using the attach workflow to connect to a running app leads to a situation where the running app has track-widget-creation enabled and attach does not. This causes errors in hot reload.

Passing in the track-widget-creation flag to attach will solve this issue.

@chingjun

Copy link
Copy Markdown
Contributor

LGTM!

@keertip
keertip merged commit b593f51 into flutter:master Apr 22, 2019
@keertip
keertip deleted the attach branch April 22, 2019 14:51
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants