Sitelet https://github.com/flutter/flutter/pull/27191
Skip to content

Revert f9e6242db (#26944) - #27191

Merged
dnfield merged 3 commits into
flutter:masterfrom
dnfield:master
Jan 28, 2019
Merged

dnfield merged 3 commits into
flutter:masterfrom
dnfield:master

Conversation

@dnfield

@dnfield dnfield commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

This is blocking the internal roll because multicast_dns depends on some unpublished/unrolled Dart features.

This will have to wait until the Dart roll catches up.

/cc @jonahwilliams @mehmetf @xster

@zoechi zoechi added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 28, 2019
@jonahwilliams

Copy link
Copy Markdown
Contributor

You'll need to run the update packages script

@dnfield

dnfield commented Jan 28, 2019

Copy link
Copy Markdown
Contributor Author

I was really hoping to avoid that becuase I don't want to introduce any other possible regressions :(

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams

Copy link
Copy Markdown
Contributor

cc @zanderso

@dnfield
dnfield merged commit c082f8d into flutter:master Jan 28, 2019
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
* Revert f9e6242

* fix pubspec

* finish pubspec upgrade
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants