Sitelet https://github.com/flutter/flutter/pull/23707
Skip to content

Resolve MaterialApp.locale, WidgetsApp.locale per supportedLocales - #23707

Merged
HansMuller merged 4 commits into
flutter:masterfrom
HansMuller:resolve_app_locale
Oct 30, 2018
Merged

HansMuller merged 4 commits into
flutter:masterfrom
HansMuller:resolve_app_locale

Conversation

@HansMuller

Copy link
Copy Markdown
Contributor

Fixes #19551

#19551 (comment) explains the problem in detail.

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder what it will be if it doesn't match... Maybe document that as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point; updated.

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller
HansMuller merged commit 06cc1d9 into flutter:master Oct 30, 2018
Xavjer pushed a commit to Xavjer/flutter that referenced this pull request Nov 1, 2018
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failure of localization in BottomNavigationBar

3 participants