Update Engine to test against JDK 25 - #193470
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenJDK dependency version from 'version:21' to 'version:25.0.2' in .ci.yaml, linux_android_emulator.json, and local_engine.json. Feedback indicates that JDK 25 is not yet released and version '25.0.2' does not exist in the CIPD repository, which will cause CI build failures during dependency resolution. It is recommended to use a valid, existing version instead.
8 of 11 tasks
Contributor
Author
|
Do not merge until: #193467 has merged |
Contributor
Author
|
#193467 has merged |
JDK 25 javadoc reports 'reference not found' for {@link ...#shouldAttachEngineToActivity()} because the builder methods take a boolean parameter. Point the links at shouldAttachEngineToActivity(boolean).
camsim99
approved these changes
Oct 3, 2026
camsim99
left a comment
Contributor
There was a problem hiding this comment.
I assume Gemini bot is wrong
Contributor
Author
yes gemini bot is wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Engine to test against JDK 25
Partially Addresses #193404
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.