Repository navigation
[flutter_test] Remove redundant null arguments in Completer.complete - #193242
Merged
auto-submit[bot] merged 1 commit intoSep 24, 2026
Merged
Conversation
Prepares for flagging redundant null argument values in avoid_redundant_argument_values (https://dart-review.googlesource.com/c/sdk/+/491341).
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the completion of Completer instances by replacing complete(null) with complete() in packages/flutter_test/lib/src/binding.dart and packages/flutter_test/test/widget_tester_test.dart. There are no review comments, and I have no feedback to provide.
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work towards dart-lang/sdk#59150 (https://dart-review.googlesource.com/c/sdk/+/491341).
The
avoid_redundant_argument_valueslint rule is being updated to flag redundantnullargument values passed to optional nullable parameters with no default value (such asCompleter.complete([FutureOr<T>? value])).Pre-launch Checklist
///).