Repository navigation
Fix unawaited async calls in fragment_shader_test and skip Vulkan in canvas_test - #193030
Merged
auto-submit[bot] merged 2 commits intoSep 23, 2026
Merged
Conversation
andywolff
force-pushed
the
fix-vulkan-host-tests
branch
from
September 21, 2026 22:50
8df35e4 to
7694178
Compare
andywolff
marked this pull request as ready for review
September 22, 2026 16:54
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies canvas_test.dart to skip a test when the platform is Linux or the Impeller backend is Vulkan. It also updates fragment_shader_test.dart by adding the await keyword to several calls of _expectShaderRendersColor and _expectShaderRendersBarcode, and marks one test block as asynchronous. There are no review comments, and no further feedback is provided.
walley892
approved these changes
Sep 22, 2026
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #193029
When I ran snapshot host tests against PR #192937, I noticed that helper methods like
_expectShaderRendersColorand_expectShaderRendersBarcodeinfragment_shader_test.dartwere missingawaits. That PR changes the buffer allocation behavior in such a way that these tests fail without these awaits, where previously they passed. So I'm sending this PR to add the awaits separately beforehand for better isolation of purpose and rollback safety.During the same test run on that PR, I also found a comment pointing to a closed issue. In
canvas_test.dart, the testtoImage and toImageSync have identical contentswas previously skipped only whenPlatform.isLinuxdue to closed issue #108835. On macOS hosts running with--impeller-backend=vulkan(MoltenVK), the same backend discrepancy occurs, so I filed #193029 and I'm updating the comment and condition to reflect this.Pre-launch Checklist
///).