Repository navigation
[devicelab] Unify web benchmarks entrypoint using BENCHMARK_SERVER_PORT define - #192765
Conversation
There was a problem hiding this comment.
Code Review
This pull request consolidates the web benchmark entrypoints by removing the separate DDC entrypoint and updating the main entrypoint to dynamically retrieve the benchmark server port via the BENCHMARK_SERVER_PORT environment variable. Feedback recommends using int.tryParse instead of int.parse to prevent potential runtime exceptions from invalid port values, as well as extracting the environment variable lookup to a local constant to avoid duplication.
|
autosubmit label was removed for flutter/flutter/192765, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
|
autosubmit label was removed for flutter/flutter/192765, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/192765, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Removes the duplicate
lib/web_benchmarks_ddc.dartentrypoint in macrobenchmarks and unifies the entrypoint target across both DDC (flutter run) and non-DDC (flutter build) modes tolib/web_benchmarks.dart.--dart-define=BENCHMARK_SERVER_PORT=$benchmarkServerPorttoflutter runin DDC mode to matchflutter build.BENCHMARK_SERVER_PORTinlib/web_benchmarks.dartviaconst String.fromEnvironment, defaulting to9999.dev/benchmarks/macrobenchmarks/lib/web_benchmarks_ddc.dart.Part of #191316
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.