Repository navigation
fix(web): hide --web-content-hash until content hashing is complete - #192663
Merged
Merged
Conversation
`--web-content-hash` currently hashes only the compiled entrypoints (flutter#191914). Static assets (flutter#191915), the service worker precache manifest (flutter#191916), and deferred loading parts (flutter#191917) are all still unhashed, so a build with the flag enabled can continue to serve stale cached content. Advertising the flag now sets an expectation the implementation does not yet meet. The flag has not shipped in any release. It landed on master in flutter#190153 on 2026-09-10, after the flutter-3.48-candidate.0 fork, so hiding it costs nothing today. It also avoids committing to the flag's boolean shape before the remaining phases show whether granularity is needed. Locks the behavior into the existing `flutter build web option visibility` tests, including the verbose-help variant, so the flag stays hidden rather than becoming verbose-only by accident. Un-hide once flutter#191915 and flutter#191916 have landed.
Contributor
There was a problem hiding this comment.
Code Review
This pull request hides the incomplete web-content-hash flag option in web_options.dart and updates the corresponding tests in build_web_test.dart to verify it is hidden. Feedback was provided to use triple-slash (///) comments for the documentation of the webContentHash member to align with the Flutter style guide.
mdebbar
previously approved these changes
Sep 12, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/192663, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
I've pushed a fix to address the failing |
Contributor
Author
|
@mdebbar need another approval, please! |
mdebbar
approved these changes
Sep 14, 2026
This was referenced Sep 15, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 16, 2026
flutter/flutter@8b3e8f5...27fec0e 2026-09-14 ttankkeo112@gmail.com Add dedicated rubber band spring for overscroll recovery in BouncingScrollPhysics (flutter/flutter#187568) 2026-09-14 engine-flutter-autoroll@skia.org Roll Skia from 83c984a6daf5 to 59904977fcbb (8 revisions) (flutter/flutter#192767) 2026-09-14 34871572+gmackall@users.noreply.github.com Request unbuffered dispatch for platform view motion events after `_PlatformViewGestureRecognizer` rejects gesture (flutter/flutter#192259) 2026-09-14 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from ZsxUUK2SfA-TrNvb8... to PDJz3b3CL31uoLOkD... (flutter/flutter#192440) 2026-09-14 codefu@google.com ci(bringup): cleanup some bringup (flutter/flutter#192752) 2026-09-14 kevmoo@users.noreply.github.com Warn users on potential removal of dart:html in dry run (flutter/flutter#192710) 2026-09-14 codefu@google.com docs: migrate design document guidance to flutter/rfc (flutter/flutter#192648) 2026-09-14 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#192499) 2026-09-14 engine-flutter-autoroll@skia.org Roll Skia from 7a6fd7ff72d5 to 83c984a6daf5 (1 revision) (flutter/flutter#192745) 2026-09-14 1961493+harryterkelsen@users.noreply.github.com RELAND: [devicelab] Clean up Chrome profile directories and trap abort signals in web benchmarks (flutter/flutter#192655) 2026-09-14 kevmoo@users.noreply.github.com fix(web): hide --web-content-hash until content hashing is complete (flutter/flutter#192663) 2026-09-14 engine-flutter-autoroll@skia.org Roll Skia from 527751088719 to 7a6fd7ff72d5 (2 revisions) (flutter/flutter#192725) 2026-09-14 engine-flutter-autoroll@skia.org Roll Skia from eaf9f82813eb to 527751088719 (1 revision) (flutter/flutter#192722) 2026-09-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AQu85JoTHCMET3Q8G... to 7R1l5MhSZZUr1Q6D1... (flutter/flutter#192719) 2026-09-14 robert.ancell@canonical.com [Linux] Clear the frame when there is nothing to render (flutter/flutter#192461) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--web-content-hashcurrently hashes only the compiled entrypoints(#191914). Static assets (#191915), the service worker precache manifest
(#191916), and deferred loading parts (#191917) are all still unhashed, so
a build with the flag enabled can continue to serve stale cached content.
Advertising the flag now sets an expectation the implementation does not
yet meet.
The flag has not shipped in any release. It landed on master in #190153 on
2026-09-10, after the flutter-3.48-candidate.0 fork, so hiding it costs
nothing today. It also avoids committing to the flag's boolean shape before
the remaining phases show whether granularity is needed.
Locks the behavior into the existing
flutter build web option visibilitytests, including the verbose-help variant, so the flag stays hidden rather
than becoming verbose-only by accident.
Un-hide once #191915 and #191916 have landed.