Migrate ios driver tests batch 4 to simulators - #192463
auto-submit[bot] merged 1 commit into
Conversation
|
This PR migrates another batch of devicelab driver tests from physical iOS devices to macOS Simulators ( What these tests do:
Why it is safe to migrate:
|
There was a problem hiding this comment.
Code Review
This pull request updates CI configurations for iOS integration tests to run on Mac hosts with a Ruby dependency, and refactors the iOS test runner to execute within a newly created iOS simulator. It also updates the iOS AppDelegates to adopt the FlutterImplicitEngineDelegate and configures scene manifests in Info.plist. Feedback on the changes suggests removing redundant simulator cleanup in the Dart test script, as testWithNewIOSSimulator already manages simulator lifecycles, and removing a redundant application:didFinishLaunchingWithOptions: override in the hello_world example.
| @implementation AppDelegate | ||
|
|
||
| - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { | ||
| [GeneratedPluginRegistrant registerWithRegistry:self]; | ||
| // Override point for customization after application launch. | ||
| return [super application:application didFinishLaunchingWithOptions:launchOptions]; | ||
| - (BOOL)application:(UIApplication *)application | ||
| didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { | ||
| return [super application:application | ||
| didFinishLaunchingWithOptions:launchOptions]; | ||
| } | ||
|
|
||
| - (void)didInitializeImplicitFlutterEngine: | ||
| (NSObject<FlutterImplicitEngineBridge> *)engineBridge { | ||
| [GeneratedPluginRegistrant registerWithRegistry:engineBridge.pluginRegistry]; | ||
| } | ||
| @end |
There was a problem hiding this comment.
The overridden application:didFinishLaunchingWithOptions: method only calls super and returns its result. Since FlutterAppDelegate already implements this method, this override is redundant and can be safely removed to simplify the class.
@implementation AppDelegate
- (void)didInitializeImplicitFlutterEngine:
(NSObject<FlutterImplicitEngineBridge> *)engineBridge {
[GeneratedPluginRegistrant registerWithRegistry:engineBridge.pluginRegistry];
}
@endRemove bringup for flutter#192463 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant in-code documentation (doc comments with `///`). - [ ] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Part of #186414
This batch migrates 2 Devicelab tests to simulators:
external_ui_integration_test_ios(external_textures_integration_test_ios)hello_world_impeller_ios_sdfsChanges:
.ci.yamlfromMac_iostoMac(Simulator) withbringup: trueand injectedrubydependency.["devicelab", "hostonly", "mac"].external_textures_integration_test_iosDevicelab task withtestWithNewIOSSimulator.dev/integration_tests/external_texturesandexamples/hello_worldiOS projects to adoptUIScene.