Repository navigation
[cupertino] Use super parameters in more places - #192148
Merged
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the constructors of the private classes _Segment and _SegmentSeparator in sliding_segmented_control.dart to use super-initializer parameters (super.key) for their keys. No review comments were provided, and there is no additional feedback.
This is work towards dart-lang/sdk#59226 The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon. Already merged "upstream" at flutter/packages#12459
dkwingsmt
force-pushed
the
super-p-cup
branch
from
September 9, 2026 03:20
5db7701 to
3b994f9
Compare
Contributor
|
autosubmit label was removed for flutter/flutter/192148, because - The status or check suite Check Code Freeze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This was referenced Sep 9, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 9, 2026
flutter/flutter@b444e78...63b9518 2026-09-09 engine-flutter-autoroll@skia.org Roll Packages from 9af9c60 to 36e088a (24 revisions) (flutter/flutter#192485) 2026-09-09 mdebbar@google.com Re-add Xcode and OpenJDK dependencies to macOS wasm local_engine builders (flutter/flutter#192238) 2026-09-09 30870216+gaaclarke@users.noreply.github.com Roll Dart SDK from 77094991d1c1 to 4be1b711b4ba (5 revisions) (flutter/flutter#192453) 2026-09-09 srawlins@google.com [material] Use super parameters in more places (flutter/flutter#192149) 2026-09-09 srawlins@google.com [cupertino] Use super parameters in more places (flutter/flutter#192148) 2026-09-09 bkonyi@google.com [flutter_tools] Gracefully handle EROFS and write-protected file system errors (flutter/flutter#192431) 2026-09-09 bkonyi@google.com [tool] Migrate BuildIOSCommand and BuildIOSArchiveCommand to modular dependency injection (flutter/flutter#192250) 2026-09-09 116356835+AbdeMohlbi@users.noreply.github.com Replace more enum instances comparison to use `equality ==` instead of `identical` and update related tests (flutter/flutter#192229) 2026-09-09 1961493+harryterkelsen@users.noreply.github.com [web] Support local screenshot and golden testing in felt test (flutter/flutter#191318) 2026-09-09 bkonyi@google.com [tool] Migrate DaemonCommand and DebugAdapterCommand to modular dependency injection (flutter/flutter#190793) 2026-09-09 1961493+harryterkelsen@users.noreply.github.com [web] Support local golden testing in flutter test (flutter/flutter#191386) 2026-09-09 bkonyi@google.com [flutter_tools] Ignore widget previews outside lib/ during LSP code generation (flutter/flutter#192326) 2026-09-09 bkonyi@google.com [flutter_tools] Read package_config.json asynchronously in loadPackageConfigWithLogging (flutter/flutter#192443) 2026-09-08 1961493+harryterkelsen@users.noreply.github.com Add precacheTestImage to flutter_test and unskip web image tests (flutter/flutter#191435) 2026-09-08 chris@bracken.jp et: Fix compile_commands.json post-processing (flutter/flutter#192395) 2026-09-08 kevmoo@users.noreply.github.com Refactor createDebuggingOptions and option registrations to OptionDescriptor (flutter/flutter#192307) 2026-09-08 bkonyi@google.com [flutter_tools] Fix test separation between `VersionFreshnessValidator` and `FlutterVersion.checkFlutterVersionFreshness` (flutter/flutter#191593) 2026-09-08 bkonyi@google.com [tool] Migrate EmulatorsCommand to modular dependency injection (flutter/flutter#190769) 2026-09-08 bkonyi@google.com [tool] Migrate Desktop build subcommands and toolchain to modular dependency injection (flutter/flutter#190781) 2026-09-08 bkonyi@google.com [tool] Migrate Tooling and Analysis commands to modular dependency injection (flutter/flutter#190788) 2026-09-08 71131015+wratheus@users.noreply.github.com Skip KGP version validation for AGP built-in Kotlin (flutter/flutter#192206) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…r#12814) flutter/flutter@b444e78...63b9518 2026-09-09 engine-flutter-autoroll@skia.org Roll Packages from 9af9c60 to 36e088a (24 revisions) (flutter/flutter#192485) 2026-09-09 mdebbar@google.com Re-add Xcode and OpenJDK dependencies to macOS wasm local_engine builders (flutter/flutter#192238) 2026-09-09 30870216+gaaclarke@users.noreply.github.com Roll Dart SDK from 77094991d1c1 to 4be1b711b4ba (5 revisions) (flutter/flutter#192453) 2026-09-09 srawlins@google.com [material] Use super parameters in more places (flutter/flutter#192149) 2026-09-09 srawlins@google.com [cupertino] Use super parameters in more places (flutter/flutter#192148) 2026-09-09 bkonyi@google.com [flutter_tools] Gracefully handle EROFS and write-protected file system errors (flutter/flutter#192431) 2026-09-09 bkonyi@google.com [tool] Migrate BuildIOSCommand and BuildIOSArchiveCommand to modular dependency injection (flutter/flutter#192250) 2026-09-09 116356835+AbdeMohlbi@users.noreply.github.com Replace more enum instances comparison to use `equality ==` instead of `identical` and update related tests (flutter/flutter#192229) 2026-09-09 1961493+harryterkelsen@users.noreply.github.com [web] Support local screenshot and golden testing in felt test (flutter/flutter#191318) 2026-09-09 bkonyi@google.com [tool] Migrate DaemonCommand and DebugAdapterCommand to modular dependency injection (flutter/flutter#190793) 2026-09-09 1961493+harryterkelsen@users.noreply.github.com [web] Support local golden testing in flutter test (flutter/flutter#191386) 2026-09-09 bkonyi@google.com [flutter_tools] Ignore widget previews outside lib/ during LSP code generation (flutter/flutter#192326) 2026-09-09 bkonyi@google.com [flutter_tools] Read package_config.json asynchronously in loadPackageConfigWithLogging (flutter/flutter#192443) 2026-09-08 1961493+harryterkelsen@users.noreply.github.com Add precacheTestImage to flutter_test and unskip web image tests (flutter/flutter#191435) 2026-09-08 chris@bracken.jp et: Fix compile_commands.json post-processing (flutter/flutter#192395) 2026-09-08 kevmoo@users.noreply.github.com Refactor createDebuggingOptions and option registrations to OptionDescriptor (flutter/flutter#192307) 2026-09-08 bkonyi@google.com [flutter_tools] Fix test separation between `VersionFreshnessValidator` and `FlutterVersion.checkFlutterVersionFreshness` (flutter/flutter#191593) 2026-09-08 bkonyi@google.com [tool] Migrate EmulatorsCommand to modular dependency injection (flutter/flutter#190769) 2026-09-08 bkonyi@google.com [tool] Migrate Desktop build subcommands and toolchain to modular dependency injection (flutter/flutter#190781) 2026-09-08 bkonyi@google.com [tool] Migrate Tooling and Analysis commands to modular dependency injection (flutter/flutter#190788) 2026-09-08 71131015+wratheus@users.noreply.github.com Skip KGP version validation for AGP built-in Kotlin (flutter/flutter#192206) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…r#12814) flutter/flutter@b444e78...63b9518 2026-09-09 engine-flutter-autoroll@skia.org Roll Packages from 9af9c60 to 36e088a (24 revisions) (flutter/flutter#192485) 2026-09-09 mdebbar@google.com Re-add Xcode and OpenJDK dependencies to macOS wasm local_engine builders (flutter/flutter#192238) 2026-09-09 30870216+gaaclarke@users.noreply.github.com Roll Dart SDK from 77094991d1c1 to 4be1b711b4ba (5 revisions) (flutter/flutter#192453) 2026-09-09 srawlins@google.com [material] Use super parameters in more places (flutter/flutter#192149) 2026-09-09 srawlins@google.com [cupertino] Use super parameters in more places (flutter/flutter#192148) 2026-09-09 bkonyi@google.com [flutter_tools] Gracefully handle EROFS and write-protected file system errors (flutter/flutter#192431) 2026-09-09 bkonyi@google.com [tool] Migrate BuildIOSCommand and BuildIOSArchiveCommand to modular dependency injection (flutter/flutter#192250) 2026-09-09 116356835+AbdeMohlbi@users.noreply.github.com Replace more enum instances comparison to use `equality ==` instead of `identical` and update related tests (flutter/flutter#192229) 2026-09-09 1961493+harryterkelsen@users.noreply.github.com [web] Support local screenshot and golden testing in felt test (flutter/flutter#191318) 2026-09-09 bkonyi@google.com [tool] Migrate DaemonCommand and DebugAdapterCommand to modular dependency injection (flutter/flutter#190793) 2026-09-09 1961493+harryterkelsen@users.noreply.github.com [web] Support local golden testing in flutter test (flutter/flutter#191386) 2026-09-09 bkonyi@google.com [flutter_tools] Ignore widget previews outside lib/ during LSP code generation (flutter/flutter#192326) 2026-09-09 bkonyi@google.com [flutter_tools] Read package_config.json asynchronously in loadPackageConfigWithLogging (flutter/flutter#192443) 2026-09-08 1961493+harryterkelsen@users.noreply.github.com Add precacheTestImage to flutter_test and unskip web image tests (flutter/flutter#191435) 2026-09-08 chris@bracken.jp et: Fix compile_commands.json post-processing (flutter/flutter#192395) 2026-09-08 kevmoo@users.noreply.github.com Refactor createDebuggingOptions and option registrations to OptionDescriptor (flutter/flutter#192307) 2026-09-08 bkonyi@google.com [flutter_tools] Fix test separation between `VersionFreshnessValidator` and `FlutterVersion.checkFlutterVersionFreshness` (flutter/flutter#191593) 2026-09-08 bkonyi@google.com [tool] Migrate EmulatorsCommand to modular dependency injection (flutter/flutter#190769) 2026-09-08 bkonyi@google.com [tool] Migrate Desktop build subcommands and toolchain to modular dependency injection (flutter/flutter#190781) 2026-09-08 bkonyi@google.com [tool] Migrate Tooling and Analysis commands to modular dependency injection (flutter/flutter#190788) 2026-09-08 71131015+wratheus@users.noreply.github.com Skip KGP version validation for AGP built-in Kotlin (flutter/flutter#192206) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work towards dart-lang/sdk#59226
The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.
Already merged "upstream" at flutter/packages#12459
Pre-launch Checklist
///).