Repository navigation
Makes snapshots not have mip levels (since they weren't propogated) - #192074
Conversation
There was a problem hiding this comment.
Code Review
This pull request disables mipmap generation when creating raster snapshots in Impeller and adds a unit test to verify that the snapshot's mipmap count is one. The review feedback recommends replacing ASSERT_NE with EXPECT_NE inside the asynchronous task runner lambda to prevent potential deadlocks, and removing an unnecessary reinterpret_cast when upcasting the rasterizer pointer.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
autosubmit label was removed for flutter/flutter/192074, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/192074, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Previously snapshots would contain 12 mips layers, but it was seen that the mips layers were never propagated so it's a waste of space best case scenario, a render bug worst case.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.