Repository navigation
[UIScene] Migrate dev/benchmarks/test_apps/stocks to UIScene lifecycle - #191651
Merged
auto-submit[bot] merged 4 commits intoAug 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the iOS runner for the stocks test app to support multiple scenes and implicit Flutter engines. It adopts the FlutterImplicitEngineDelegate protocol in AppDelegate, moves plugin registration to didInitializeImplicitFlutterEngine:, and configures UIApplicationSceneManifest in Info.plist. The review feedback recommends changing the parameter type of didInitializeImplicitFlutterEngine: from NSObject * to id to match the protocol definition and prevent compilation warnings.
vashworth
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #188336