Repository navigation
Clarifies blur group optimization - #191613
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for backdrop filters in basic.dart to clarify how multiple filters can be combined into a single rendering operation, explaining the requirement for identical filter configurations and the effect of bounded blurs. The feedback identifies an incorrect class reference to ImageFilterConfig.blur in the newly added documentation, which would lead to a broken link in the generated API documentation.
| /// | ||
| /// To combine the filter passes into a single operation, the resolved filters | ||
| /// across the group must have identical properties. For example, using a "bounded" | ||
| /// blur ([ImageFilterConfig.blur] with `bounded: true` or [ui.ImageFilter.blur] |
There was a problem hiding this comment.
The reference [ImageFilterConfig.blur] is incorrect because there is no ImageFilterConfig class in the Flutter framework or dart:ui. This will result in a broken link in the generated API documentation. Please verify the class name or reference the correct class (e.g., ImageFilter or similar configuration class if one was recently introduced).
There was a problem hiding this comment.
Yea, thats a reference to a higher API. I think it's worth keeping.
andywolff
left a comment
There was a problem hiding this comment.
I was too slow, but LGTM to me too
issue: #191207
This clarifies that the blur groups need identical properties to collapse the blur.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.