Repository navigation
Revert: [wimp] Turn multithreading on for wimp. - #191423
Conversation
This reverts commit c418ca5.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates skwasm_loader.js to force single-threaded mode for Skwasm when config.enableWimp is enabled, addressing stability issues with multi-threaded Wimp. There are no review comments, and I have no additional feedback to provide.
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
Reverts: [wimp] Turn multithreading on for wimp.
Initiated by: @bkonyi
Reason for reverting: failing Linux linux_web_engine_tests on tree.
Original PR Author: @eyebrowsoffire
Reviewed By: @mdebbar
The original PR description is provided below:
After #190048, we no longer have multthreading issues with wimp, so we should turn multithreading on.
This addresses #178749