Repository navigation
[material] Remove unused parameters from constructors of generic classes - #191399
Conversation
…lasses. We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839 This is mirrored at flutter/packages#12458
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
There was a problem hiding this comment.
Code Review
This pull request cleans up several constructors across the Material library by removing unused super.key parameters from private widgets, including _AutocompleteOptions, _ModalBottomSheet, _DropdownMenuItemButton, _DropdownMenu, _DropdownRoutePage, _MenuItem, _PopupMenu, and _SegmentedButtonRenderWidget. Additionally, in DropdownButton._formField, the underline and menuWidth parameters are removed and explicitly initialized to null, and the _CustomPageRoute constructor in the scaffold tests is simplified. There are no review comments, and I have no feedback to provide.
|
flutter/packages#12458 has landed. |
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . This code is frozen but I assume that linting tools will complain if we don't make this change. Given that it should have no effect on users at all, I think it's fine to land.
We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes.
This is work towards dart-lang/sdk#47839
This is mirrored at flutter/packages#12458
Pre-launch Checklist
///).