Repository navigation
[analysis] Clean up legacy custom rules and private-lints in analyze.dart - #191128
Merged
auto-submit[bot] merged 4 commits intoAug 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes custom private lints and their associated tests from the dev/bots directory, including rules for double.clamp, Stopwatch, RenderBox intrinsics, and public State subtypes. Additionally, it updates a reference comment in packages/flutter/lib/src/widgets/framework.dart to point to the new location of these rules under dev/flutter_analyzer_plugin. There are no review comments, and I have no feedback to provide.
…nup to analyze_test
srawlins
approved these changes
Aug 15, 2026
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the legacy
dev/bots/custom_rules/folder andprivate-lintsvalidation indev/bots/analyze.dartnow that all rules have been migrated todev/flutter_analyzer_plugin.Changes
dev/bots/custom_rules/directory and all legacy rule implementations._verifyPrivateLintsand'private-lints'fromdev/bots/analyze.dart.dev/bots/test/analyze_test.dart.packages/flutter/lib/src/widgets/framework.dart.