Repository navigation
ignore soon-to-be-removed plugins_in_inner_options issue - #191071
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a commented-out inline ignore directive to analysis_options.yaml. Feedback indicates that the Dart analyzer does not support inline ignore comments within YAML configuration files, making the added directive ineffective for suppressing warnings.
Comment on lines
+11
to
+12
| # This error code will no longer be reported here. Until dart rolls in, we need to just ignore the issue. | ||
| # ignore: unrecognized_error_code |
Contributor
There was a problem hiding this comment.
The Dart analyzer does not support inline ignore comments (such as # ignore: unrecognized_error_code) within YAML configuration files like analysis_options.yaml. Inline ignores are only supported in Dart source files (.dart). As a result, this comment is ineffective and will not suppress the warning when the error code is removed.
bkonyi
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bkonyi landed #191022 around the same time I landed https://dart-review.googlesource.com/c/sdk/+/534500. They sort of conflict in that Ben's PR references
plugins_in_inner_optionswhich my CL deletes. So we can ignore theunrecognized_error_codeuntil a roll makes it in.See https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8673632836896349697/+/u/analyze_Flutter_repositories/stdout which I believe is from the HH bot.