Repository navigation
Reland "Make Xcode workspace cleaning optional during flutter clean" - #191023
Merged
Merged
Conversation
Fixes flutter#183946 This commit introduces a new `--clean-xcode-workspace` flag (defaulting to false) to `flutter clean` which allows skipping the expensive `xcodebuild -list` execution that inherently triggers Swift Package resolution over the internet. By default, Flutter will now instantly clean local build directories without polling Xcode. Additionally, this introduces an O(1) whitelist optimization to skip virtual SwiftPM schemes, significantly speeding up Xcode workspace processing when it is explicitly requested.
okorohelijah
marked this pull request as ready for review
August 12, 2026 20:22
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new --include-xcode-workspace flag to the flutter clean command, ensuring Xcode workspaces are only cleaned when explicitly requested. It updates command-line options, error diagnostic messages, and tests accordingly. Feedback highlights a potential runtime ArgumentError caused by checking the unregistered scheme option in clean.dart, and identifies redundant calls to _parseMissingModule in mac.dart.
vashworth
approved these changes
Aug 12, 2026
This was referenced Aug 13, 2026
|
@okorohelijah @vashworth Can I ask which Flutter release you think this will be available in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR skipped cleaning Xcode's
DerivedDataClang module cache by default. This caused theplugin_lint_mactest to fail because the test dynamically togglesuse_frameworks!off and expects a clean slate. SinceDerivedDatawasn't wiped, Xcode's cached index expected the previously generated.framework/Modules/module.modulemapto exist inbuild/(whichflutter cleanhad just deleted), resulting in amodule map file not foundbuild failure. To fix this, the--include-xcode-workspaceflag is now added to the test. Since togglinguse_frameworks!isn't a general use case , there is now an actionable error to gracefully guide developers to runflutter clean --include-xcode-workspaceif they hit this cache corruption.List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Fixes #183946, #173940 and #127708 too
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.