Repository navigation
[input] Migrate fuchsia.ui.pointerinjector to TouchSource - #190855
Merged
caroqliu merged 3 commits intoAug 19, 2026
Merged
Conversation
caroqliu
force-pushed
the
fuchsia-migrate-pointerinjector
branch
from
August 10, 2026 17:22
436fe19 to
4d41694
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the PointerInjectorDelegate class and its associated source, header, and unit test files from the Fuchsia platform shell. Consequently, it removes references to the fuchsia.ui.pointerinjector.Registry service from build configurations, component manifests, integration tests, and the PlatformView implementation. No review comments were provided, so there is no additional feedback.
caroqliu
force-pushed
the
fuchsia-migrate-pointerinjector
branch
from
August 11, 2026 17:14
4d41694 to
13259dc
Compare
Removed fuchsia.ui.pointerinjector.Registry usages, dependencies, manifests, and the PointerInjectorDelegate class in the Flutter Runner. Input events for child views are routed directly by Scenic to child TouchSources in Flatland, making parent-side pointer injection obsolete. Test: touch-input-test, mouse-input-test, text-input-test, flutter_runner_tests
caroqliu
force-pushed
the
fuchsia-migrate-pointerinjector
branch
from
August 13, 2026 20:05
13259dc to
58507f1
Compare
zijiehe-google-com
approved these changes
Aug 17, 2026
zijiehe-google-com
left a comment
Contributor
There was a problem hiding this comment.
I think this is LGTM 💯
10 tasks done
This was referenced Aug 20, 2026
dayanruben
pushed a commit
to dayanruben/flutter
that referenced
this pull request
Aug 22, 2026
…utter#190855) (flutter#191509) This reverts commit 7099814. See b/550157001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed fuchsia.ui.pointerinjector.Registry usages, dependencies, manifests, and the PointerInjectorDelegate class in the Flutter Runner. Input events for child views are routed directly by Scenic to child TouchSources in Flatland, making parent-side pointer injection obsolete.
Test: touch-input-test, mouse-input-test, text-input-test, flutter_runner_tests
Issue: b/42175685
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.